-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Libv8::Node::Paths with RubyGems >=3.3.21 on *-linux-gnu platforms #36
base: master
Are you sure you want to change the base?
Commits on Jan 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2e94fc2 - Browse repository at this point
Copy the full SHA 2e94fc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21eeb92 - Browse repository at this point
Copy the full SHA 21eeb92View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6cc61e - Browse repository at this point
Copy the full SHA a6cc61eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f55ed74 - Browse repository at this point
Copy the full SHA f55ed74View commit details
Commits on Aug 26, 2022
-
- Add make targets for local building and testing This is especially useful for building and testing on Darwin - Split makefile in two: one direct and one for docker This is necessary because direct targets and dockerized targets overlap on Linux. - Fix a few Dockerfile oversights due to updates in libexec
Configuration menu - View commit details
-
Copy full SHA for 90b7d78 - Browse repository at this point
Copy the full SHA 90b7d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c54319 - Browse repository at this point
Copy the full SHA 5c54319View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6a5708 - Browse repository at this point
Copy the full SHA f6a5708View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4d6da8 - Browse repository at this point
Copy the full SHA f4d6da8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1328005 - Browse repository at this point
Copy the full SHA 1328005View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe34cc6 - Browse repository at this point
Copy the full SHA fe34cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4460470 - Browse repository at this point
Copy the full SHA 4460470View commit details -
Configuration menu - View commit details
-
Copy full SHA for 690c03f - Browse repository at this point
Copy the full SHA 690c03fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff6449f - Browse repository at this point
Copy the full SHA ff6449fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5a47ed - Browse repository at this point
Copy the full SHA b5a47edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3be6699 - Browse repository at this point
Copy the full SHA 3be6699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d3ed36 - Browse repository at this point
Copy the full SHA 7d3ed36View commit details -
Add more cross-compilation options
- arm64-darwin from x86_64-darwin (also added to CI) - x86_64-darwin from arm64-darwin - x86_64-linux from aarch64-linux
Configuration menu - View commit details
-
Copy full SHA for 461eedc - Browse repository at this point
Copy the full SHA 461eedcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f53bf1e - Browse repository at this point
Copy the full SHA f53bf1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b7f57d - Browse repository at this point
Copy the full SHA 6b7f57dView commit details
Commits on Aug 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 98078bc - Browse repository at this point
Copy the full SHA 98078bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98c9258 - Browse repository at this point
Copy the full SHA 98c9258View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fa4743 - Browse repository at this point
Copy the full SHA 7fa4743View commit details
Commits on Jan 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e35a4fa - Browse repository at this point
Copy the full SHA e35a4faView commit details -
Optimize 'libexec/build-monolith' on Linux
Use `xargs` to build the `ar` command line instead of running `ar` manually to reduce startup costs. Build the symbol table after adding each file instead of continually rebuilding it.
Configuration menu - View commit details
-
Copy full SHA for d742196 - Browse repository at this point
Copy the full SHA d742196View commit details
Commits on Jan 11, 2023
-
Skip compilation on TruffleRuby
* Running libv8 on GraalVM LLVM is unlikely to ever work, instead using Graal.js makes more sense. This is already the case in mini_racer. libv8-node is a necessary dependency of mini_racer on CRuby, so for TruffleRuby the extconf.rb simply creates a dummy Makefile.
Configuration menu - View commit details
-
Copy full SHA for abae20e - Browse repository at this point
Copy the full SHA abae20eView commit details
Commits on Jan 12, 2023
-
Merge pull request rubyjs#38 from eregon/truffleruby
Skip compilation on TruffleRuby
Configuration menu - View commit details
-
Copy full SHA for 6da5856 - Browse repository at this point
Copy the full SHA 6da5856View commit details
Commits on Jan 19, 2023
-
This fixes an issue where functions that require ICU data segfault the process due to an unexpected lack of ICU data. The actual ICU data is provided by the icudt71_dat object.
Configuration menu - View commit details
-
Copy full SHA for db76c05 - Browse repository at this point
Copy the full SHA db76c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8c6b58 - Browse repository at this point
Copy the full SHA d8c6b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for f17c160 - Browse repository at this point
Copy the full SHA f17c160View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdd9edf - Browse repository at this point
Copy the full SHA fdd9edfView commit details
Commits on Jan 20, 2023
-
Add initial multi-platform support for test.
Linking on Linux currently errors with `undefined reference to `'dlsym'`
Configuration menu - View commit details
-
Copy full SHA for 261889c - Browse repository at this point
Copy the full SHA 261889cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf1dff5 - Browse repository at this point
Copy the full SHA bf1dff5View commit details -
fix building test on linux on some build setups
(including our codespace)
Configuration menu - View commit details
-
Copy full SHA for d8d1567 - Browse repository at this point
Copy the full SHA d8d1567View commit details -
Configuration menu - View commit details
-
Copy full SHA for f803993 - Browse repository at this point
Copy the full SHA f803993View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0248883 - Browse repository at this point
Copy the full SHA 0248883View commit details -
attempt to move forward docker image to newer version
and one that supports the newer cmake.
Configuration menu - View commit details
-
Copy full SHA for 02f6af3 - Browse repository at this point
Copy the full SHA 02f6af3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd333f5 - Browse repository at this point
Copy the full SHA fd333f5View commit details -
Alpine Linux's `ar` program doesn't support having objects with the same name in the archive twice, so we have to use the GNU extension for including paths. This commit *should* honestly be split into multiple separate commits, but unfortunately pretty much all of these changes have to be applied as a unit or a build step fails.
Configuration menu - View commit details
-
Copy full SHA for d016d23 - Browse repository at this point
Copy the full SHA d016d23View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1af510 - Browse repository at this point
Copy the full SHA b1af510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c7341 - Browse repository at this point
Copy the full SHA 29c7341View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a61bac - Browse repository at this point
Copy the full SHA 9a61bacView commit details
Commits on Jan 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 97560d6 - Browse repository at this point
Copy the full SHA 97560d6View commit details
Commits on Jan 23, 2023
-
Merge pull request rubyjs#37 from seanmakesgames/add_test
Add cpp test, fix locale issues and fix CI issues
Configuration menu - View commit details
-
Copy full SHA for 543ee88 - Browse repository at this point
Copy the full SHA 543ee88View commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0d462cb - Browse repository at this point
Copy the full SHA 0d462cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f38ca6d - Browse repository at this point
Copy the full SHA f38ca6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fad627 - Browse repository at this point
Copy the full SHA 0fad627View commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dcb3894 - Browse repository at this point
Copy the full SHA dcb3894View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db6396 - Browse repository at this point
Copy the full SHA 4db6396View commit details
Commits on Jun 24, 2024
-
Fix Libv8::Node::Paths with RubyGems >=3.3.21 on *-linux-gnu platforms
RubyGems 3.3.21 changed the value format of `Gem::Platform.local` for Ruby configured with `*-linux-gnu` as the platform name. ```console $ ruby -ve 'p Gem::VERSION; p Gem::Platform.local.to_s' ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux-gnu] "3.3.20" "x86_64-linux" $ ruby -ve 'p Gem::VERSION; p Gem::Platform.local.to_s' ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux-gnu] "3.3.21" "x86_64-linux-gnu" $ ruby -ve 'p Gem::VERSION; p Gem::Platform.local.to_s' ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a) [x86_64-linux-gnu] "3.3.24" "x86_64-linux-gnu" ``` As you can see, it now has the `-gnu` prefix and `Libv8::Node::Paths.object_paths` thus has it when the built binary actually lives in the directory `x86_64-linux`, breaking the build of the gems like mini_racer on those platforms. [`RUBY_TARGET_PLATFORM` is set to `*-linux`](https://github.com/knu/libv8-node/blob/ad9105562185571f7b486f7770986f6a160318b2/libexec/platform#L28-L29), so `Libv8::Node::Paths.platform` needs to align with that.
Configuration menu - View commit details
-
Copy full SHA for f6a5a86 - Browse repository at this point
Copy the full SHA f6a5a86View commit details