fix unit test

rudderlabs · Mar 13, 2024 · c94723d · c94723d
1 parent d3e3529
commit c94723d
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/testhelper/httptest/httptest_test.go b/testhelper/httptest/httptest_test.go
@@ -46,7 +46,7 @@ func TestServer(t *testing.T) {
 
 func TestUnStartedServer(t *testing.T) {
 	// create a server which is not started
-	httpUnStartedServer := kithttptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	httpUnStartedServer := kithttptest.NewUnStartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		_, _ = w.Write([]byte("Hello, world!"))
 	}))
 
@@ -55,12 +55,8 @@ func TestUnStartedServer(t *testing.T) {
 		statusCode int
 	)
 	require.Never(t, func() bool {
-		resp, err := http.Get(httpUnStartedServer.URL)
+		resp, err := http.Get("http://" + httpUnStartedServer.Listener.Addr().String())
 		defer func() { httputil.CloseResponse(resp) }()
-		if err == nil {
-			statusCode = resp.StatusCode
-			body, err = io.ReadAll(resp.Body)
-		}
 		return err == nil
 	}, 5*time.Second, time.Second, "connected to an un-started server")