-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: gcs manager upload condition - DoesNotExist (#479)
Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> Co-authored-by: Leonidas Vrachnis <leo.al.vra@gmail.com>
- Loading branch information
3 people
committed
May 28, 2024
1 parent
b45393b
commit cc87fd5
Showing
6 changed files
with
180 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| package filemanager | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "os" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/rudderlabs/rudder-go-kit/config" | ||
| "github.com/rudderlabs/rudder-go-kit/logger" | ||
| "github.com/rudderlabs/rudder-go-kit/testhelper" | ||
|
|
||
| "github.com/fsouza/fake-gcs-server/fakestorage" | ||
| ) | ||
|
|
||
| func TestGCSManagerOpts(t *testing.T) { | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| // testcases: | ||
| tcs := []struct { | ||
| name string | ||
| gcsUploadIfNotExist bool | ||
| }{ | ||
| { | ||
| name: "without UploadIfNotExist", | ||
| gcsUploadIfNotExist: true, | ||
| }, | ||
| { | ||
| name: "with UploadIfNotExist", | ||
| gcsUploadIfNotExist: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range tcs { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| port, err := testhelper.GetFreePort() | ||
| require.NoError(t, err) | ||
|
|
||
| server, err := fakestorage.NewServerWithOptions(fakestorage.Options{ | ||
| InitialObjects: []fakestorage.Object{ | ||
| { | ||
| ObjectAttrs: fakestorage.ObjectAttrs{ | ||
| BucketName: "test-bucket", | ||
| Name: "test-prefix/testFile", | ||
| }, | ||
| Content: []byte("inside the file"), | ||
| }, | ||
| }, | ||
| Scheme: "http", | ||
| Host: "127.0.0.1", | ||
| Port: uint16(port), | ||
| }) | ||
| require.NoError(t, err) | ||
| defer server.Stop() | ||
|
|
||
| gcsURL := fmt.Sprintf("%s/storage/v1/", server.URL()) | ||
| t.Log("GCS URL:", gcsURL) | ||
|
|
||
| conf := map[string]interface{}{ | ||
| "bucketName": "test-bucket", | ||
| "prefix": "test-prefix", | ||
| "endPoint": gcsURL, | ||
| "disableSSL": true, | ||
| "jsonReads": true, | ||
| } | ||
| m, err := New(&Settings{ | ||
| Provider: "GCS", | ||
| Config: conf, | ||
| Logger: logger.NOP, | ||
| Conf: config.New(), | ||
| GCSUploadIfNotExist: tc.gcsUploadIfNotExist, | ||
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| tempDir := t.TempDir() | ||
| f, err := os.Create(tempDir + "/testFile") | ||
| require.NoError(t, err) | ||
|
|
||
| t.Log("pre-existing file") | ||
| uploadedFile, err := m.Upload(ctx, f) | ||
| if tc.gcsUploadIfNotExist { | ||
| require.Equal(t, UploadedFile{}, uploadedFile) | ||
| require.ErrorIs(t, err, ErrPreConditionFailed) | ||
| } else { | ||
| require.NoError(t, err) | ||
| } | ||
|
|
||
| t.Run("new file", func(t *testing.T) { | ||
| tempDir := t.TempDir() | ||
| f, err := os.Create(tempDir + "/testFile-new") | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = m.Upload(ctx, f) | ||
| require.NoError(t, err) | ||
| }) | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters