fix: race condition for err variable when statsd start is called #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the error variable declared in the start function syntax is modified by the goroutine at line 48. Since we are returning nil at the end, err variable is set to nil. leading to a potential data race by main routine and go routine
Test this in go playground
I got to know about it when I was testing this pr for a race condition.
These are the logs, i got when i ran rudder-sources in race condition
Security