Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race condition for err variable when statsd start is called #44

Merged
merged 1 commit into from
May 8, 2023
Merged

fix: race condition for err variable when statsd start is called #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ coverage.html
*.orig
**/gomock_reflect_*/*
ginkgo.report
vendor/
3 changes: 2 additions & 1 deletion stats/statsd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ type statsdStats struct {
backgroundCollectionCancel func()
}

func (s *statsdStats) Start(ctx context.Context, goFactory GoRoutineFactory) (err error) {
func (s *statsdStats) Start(ctx context.Context, goFactory GoRoutineFactory) error {
if !s.config.enabled.Load() {
return nil
}
Expand All @@ -34,6 +34,7 @@ func (s *statsdStats) Start(ctx context.Context, goFactory GoRoutineFactory) (er

// NOTE: this is to get at least a dummy client, even if there is a failure.
// So, that nil pointer error is not received when client is called.
var err error
s.state.client.statsd, err = statsd.New(s.state.conn, s.statsdConfig.statsdTagsFormat(), s.statsdConfig.statsdDefaultTags())
if err == nil {
s.logger.Info("StatsD client setup succeeded.")
Expand Down