chore: isTruncated should be a debug log #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
approved these changes
Aug 27, 2024
atzoum
requested review from
lvrach,
fracasula,
cisse21,
achettyiitr and
Sidddddarth
Merged
achettyiitr
approved these changes
Aug 27, 2024
fracasula
reviewed
Aug 27, 2024
| @@ -290,7 +290,7 @@ type digitalOceanListSession struct { | |||
| func (l *digitalOceanListSession) Next() (fileObjects []*FileInfo, err error) { | |||
| manager := l.manager | |||
| if !l.isTruncated { | |||
| manager.logger.Infof("Manager is truncated: %v so returning here", l.isTruncated) | |||
| manager.logger.Debugf("Manager is truncated: %v so returning here", l.isTruncated) | |||
There was a problem hiding this comment.
When possible we should try to use the structured non-sugared logger, i.e. manager.logger.Debugn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manager is truncated: ...should be a debug log instead of InfoLinear Ticket
Resolves PRO-3247
Security