Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: isTruncated should be a debug log #606

Merged
merged 1 commit into from
Aug 27, 2024
Merged

chore: isTruncated should be a debug log #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion filemanager/digitaloceanmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ type digitalOceanListSession struct {
func (l *digitalOceanListSession) Next() (fileObjects []*FileInfo, err error) {
manager := l.manager
if !l.isTruncated {
manager.logger.Infof("Manager is truncated: %v so returning here", l.isTruncated)
manager.logger.Debugf("Manager is truncated: %v so returning here", l.isTruncated)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When possible we should try to use the structured non-sugared logger, i.e. manager.logger.Debugn.

return
}
fileObjects = make([]*FileInfo, 0)
Expand Down
2 changes: 1 addition & 1 deletion filemanager/miniomanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ type minioListSession struct {
func (l *minioListSession) Next() (fileObjects []*FileInfo, err error) {
manager := l.manager
if !l.isTruncated {
manager.logger.Infof("Manager is truncated: %v so returning here", l.isTruncated)
manager.logger.Debugf("Manager is truncated: %v so returning here", l.isTruncated)
return
}
fileObjects = make([]*FileInfo, 0)
Expand Down
2 changes: 1 addition & 1 deletion filemanager/s3manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ type s3ListSession struct {
func (l *s3ListSession) Next() (fileObjects []*FileInfo, err error) {
manager := l.manager
if !l.isTruncated {
manager.logger.Infof("Manager is truncated: %v so returning here", l.isTruncated)
manager.logger.Debugf("Manager is truncated: %v so returning here", l.isTruncated)
return
}
fileObjects = make([]*FileInfo, 0)
Expand Down
Loading