Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config logger and stats common packages #1

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Mar 14, 2023

Description

Adding config, logger & stats packages, along with some test helpers.

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@b2a57ab). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 31ff9f5 differs from pull request most recent head a7a3669. Consider uploading reports for the commit a7a3669 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   82.33%           
=======================================
  Files           ?       32           
  Lines           ?     2134           
  Branches        ?        0           
=======================================
  Hits            ?     1757           
  Misses          ?      309           
  Partials        ?       68           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

utils/httputil/client.go Outdated Show resolved Hide resolved
config/env.go Outdated Show resolved Hide resolved
@atzoum atzoum requested review from lvrach and fracasula March 15, 2023 08:59
@atzoum atzoum merged commit b036bd4 into main Mar 15, 2023
@atzoum atzoum deleted the feat.initialLoad branch March 15, 2023 14:56
@github-actions github-actions bot mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants