Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config deadlock by trying to acquire a read lock twice #118

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Sep 15, 2023

Description

Internal callers which have already acquired a read lock on vLock are now using isSetInternal which doesn't acquire any lock.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fda5211) 79.37% compared to head (677a087) 79.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   79.37%   79.38%           
=======================================
  Files          68       68           
  Lines        5087     5089    +2     
=======================================
+ Hits         4038     4040    +2     
  Misses        849      849           
  Partials      200      200           
Files Changed Coverage Δ
config/config.go 82.79% <100.00%> (+0.18%) ⬆️
config/hotreloadable.go 87.62% <100.00%> (ø)
config/load.go 92.26% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atzoum atzoum merged commit 458381e into main Sep 15, 2023
8 checks passed
@atzoum atzoum deleted the fix.deadLock branch September 15, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants