fix: handle the case when the gateway suffix (in HA mode) ends up being a number #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raman2805
force-pushed
the
fix.getInstanceID
branch
from
4e748bc
to
507c141
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 76.38% 78.46% +2.08%
==========================================
Files 41 37 -4
Lines 2837 2721 -116
==========================================
- Hits 2167 2135 -32
+ Misses 564 486 -78
+ Partials 106 100 -6
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
lvrach
reviewed
Apr 4, 2023
config/misc.go
Outdated
Comment on lines
38
to
39
| regexGwHa := regexp.MustCompile(`^.*-gw-ha-\d+-\w+-\w+$`) | ||
| regexGwNonHaOrProcessor := regexp.MustCompile(`^.*-\d+$`) |
There was a problem hiding this comment.
We can define those regexes as a global vars in the file, so we don't have to compile everytime GetInstanceID is called
atzoum
approved these changes
Apr 4, 2023
BonapartePC
approved these changes
Apr 5, 2023
atzoum
force-pushed
the
fix.getInstanceID
branch
from
33e1356
to
7d5c04b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To get the instance id of the pod, we were first checking that the last token (split by -) is an integer or not, in which case we returned that. If not, we used the third to last token (to handle the case for gw ha pods) to get the index. However, this breaks down if the ha pods end up receiving a suffix which is an integer. This change fixes that issue.