Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: soft failure for invalid instruments #181

Merged

Conversation

fracasula
Copy link
Collaborator

Description

Soft failure for invalid instruments.

Linear Ticket

< Linear_Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@github-actions github-actions bot added the stats label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (73dde37) 79.12% compared to head (7d3e4f2) 79.23%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   79.12%   79.23%   +0.11%     
==========================================
  Files          70       70              
  Lines        5174     5183       +9     
==========================================
+ Hits         4094     4107      +13     
+ Misses        875      873       -2     
+ Partials      205      203       -2     
Files Coverage Δ
stats/otel.go 76.17% <91.66%> (+2.48%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fracasula fracasula merged commit 0f91858 into main Oct 30, 2023
10 checks passed
@fracasula fracasula deleted the fix/pipe-460-fix-hard-panic-on-instrument-creation-failure branch October 30, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants