Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ack to kafka client #327

Merged
merged 3 commits into from
Feb 12, 2024
Merged

feat: add ack to kafka client #327

merged 3 commits into from
Feb 12, 2024

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Feb 12, 2024 •
edited by achettyiitr
Loading

Description

add ack capability to kafka client

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-754/add-acks-capability-to-kafka-client

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (111bd3b) 79.52% compared to head (a9d5173) 79.54%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
+ Coverage   79.52%   79.54%   +0.01%     
==========================================
  Files          85       73      -12     
  Lines        6545     5602     -943     
==========================================
- Hits         5205     4456     -749     
+ Misses       1078      934     -144     
+ Partials      262      212      -50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mihir20
mihir20 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments else LGTM

kafkaclient/client_test.go Outdated Show resolved Hide resolved
kafkaclient/client_test.go Outdated Show resolved Hide resolved
kafkaclient/client_test.go Outdated Show resolved Hide resolved
kafkaclient/client_test.go Outdated Show resolved Hide resolved
kafkaclient/client_test.go Outdated Show resolved Hide resolved
fracasula
fracasula reviewed Feb 12, 2024
View reviewed changes
kafkaclient/client_test.go Outdated Show resolved Hide resolved
kafkaclient/client_test.go Show resolved Hide resolved
fracasula
fracasula approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've added a couple comments above 👍

@BonapartePC BonapartePC merged commit b4e3c34 into main Feb 12, 2024
12 checks passed
@BonapartePC BonapartePC deleted the feat.KafkaAck branch February 12, 2024 09:36
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achettyiitr achettyiitr achettyiitr approved these changes

@mihir20 mihir20 mihir20 approved these changes

@fracasula fracasula fracasula approved these changes

Assignees
No one assigned
Labels
with tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BonapartePC @fracasula @mihir20 @achettyiitr