feat: add remoteFilePath support and create remote directory in sftp #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
approved these changes
Apr 22, 2024
|
should we also automatically create folder when file is uploaded? |
Didn't get this. We are creating the remote directory/folder when file is uploaded |
Gauravudia
changed the title
mihir20
reviewed
Apr 30, 2024
| @@ -138,10 +138,11 @@ func TestUpload(t *testing.T) { | |||
|
|
|||
| mockSFTPClient := mock_sftp.NewMockClient(ctrl) | |||
| mockSFTPClient.EXPECT().Create(gomock.Any()).Return(&nopWriteCloser{remoteBuf}, nil) | |||
| mockSFTPClient.EXPECT().MkdirAll(gomock.Any()).Return(nil) | |||
There was a problem hiding this comment.
would it be better if instead of using gomock.Any() actual value that is expected for the fn is used? i.e someRemotePath
Similarly for other mocks?
There was a problem hiding this comment.
Does it make any difference? Used Any() to increase the readability
There was a problem hiding this comment.
Using actual expected value, is better for testing point of view.
ItsSudip
approved these changes
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Resolved INT-2048
https://linear.app/rudderstack/issue/INT-2048/go-kit-create-remote-directory-in-sftp
Security