feat: monitor sql database #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
feat.monitor-db
branch
from
37976cf
to
fb61150
Compare
achettyiitr
force-pushed
the
feat.monitor-db
branch
from
fb61150
to
21f9e0d
Compare
Sidddddarth
reviewed
Apr 23, 2024
sqlutil/monitor.go
Outdated
Comment on lines
22
to
26
| maxOpenConnectionsStat := statsFactory.NewStat(dbIdentifier+".db.max_open_connections", stats.CountType) | ||
| openConnectionsStat := statsFactory.NewStat(dbIdentifier+".db.open_connections", stats.CountType) | ||
| inUseStat := statsFactory.NewStat(dbIdentifier+".db.in_use", stats.CountType) | ||
| idleStat := statsFactory.NewStat(dbIdentifier+".db.idle", stats.CountType) | ||
| waitCountStat := statsFactory.NewStat(dbIdentifier+".db.wait_count", stats.CountType) |
There was a problem hiding this comment.
wouldn't a gauge make more sense here..?
There was a problem hiding this comment.
Probably everything can be Gauge instead of WaitDuration?
|
Suggestion: aggregate things like |
Good point. I was thinking of adding tags instead of creating different stat per identifier. It would be easy to aggregate. |
lvrach
approved these changes
Apr 24, 2024
achettyiitr
force-pushed
the
feat.monitor-db
branch
from
138c42b
to
99826a5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Security