Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for custom redis docker repository #467

Merged
merged 4 commits into from
May 17, 2024
Merged

feat: add support for custom redis docker repository #467

merged 4 commits into from
May 17, 2024

Conversation

sanpj2292
Copy link
Contributor

Description

We are supporting loading a custom docker repository for Redis. Now if someone wants to load a custom redis docker repo, they would need to use WithRepository

Linear Ticket

Resolves INT-2095

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@sanpj2292 sanpj2292 self-assigned this May 17, 2024
fracasula
fracasula approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comment.

testhelper/docker/resource/redis/redis.go Outdated Show resolved Hide resolved
fracasula
fracasula requested changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@fracasula fracasula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting the changes left in the previous comments. There seems to be a bug.

@sanpj2292 sanpj2292 requested a review from fracasula May 17, 2024 10:23
@fracasula fracasula merged commit 55606f8 into main May 17, 2024
10 checks passed
@fracasula fracasula deleted the feat.redis-repository-args branch May 17, 2024 13:12
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achettyiitr achettyiitr achettyiitr approved these changes

@fracasula fracasula fracasula approved these changes

Assignees

@sanpj2292 sanpj2292

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanpj2292 @fracasula @achettyiitr