Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compress #621

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: compress #621

merged 1 commit into from
Sep 3, 2024

Conversation

fracasula
Copy link
Collaborator

Description

Removing constructors for creation algorithm and level alone (i.e. NewCompressionAlgorithm and NewCompressionLevel) since they don't make sense called alone anymore.

Improved tests.

Linear Ticket

< Linear_Link >

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Member

@Sidddddarth Sidddddarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need for an exported NewSettings too..?

@fracasula fracasula merged commit ae791c9 into main Sep 3, 2024
12 of 13 checks passed
@fracasula fracasula deleted the compress-fix branch September 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants