Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release all Java modules with version 3.1.2 #113

Merged
merged 22 commits into from
Aug 2, 2024
Merged

fix: release all Java modules with version 3.1.2 #113

merged 22 commits into from
Aug 2, 2024

Conversation

1abhishekpandey
Copy link

@1abhishekpandey 1abhishekpandey commented Aug 1, 2024 •
edited
Loading

Description of the change

  • We observed that previously we missed releasing other Java SDK modules and only released analytics-core. So in this PR, we've updated to the next release version 3.1.2 and we are going to release that.
  • We have also removed obsolete modules analytics-cli and analytics-spring-boot-starter.
  • Fixed sonar analysis github action.
  • Provide back support for Java v8. We have reverted the changes that we did in this commit: 6eb27ac.
  • Removed com.thoughtworks.xstream. It was causing some issue with the release process.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@1abhishekpandey 1abhishekpandey self-assigned this Aug 1, 2024
saikumarrs
saikumarrs reviewed Aug 1, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@1abhishekpandey
chore: address snyk issues
3068a37 
Update okhttp version to 4.12.0 to address the okio vulnerability issue
@1abhishekpandey
chore: remove commented out code from pom.xml file
e8bb904
@1abhishekpandey
chore: remove analytics-cli module
326578b 
This module is irrelevant and was also causing some issues with the release process.
@1abhishekpandey
chore: use placeholder for version in the README.md
a8da8b6
ChryssaAliferi
ChryssaAliferi approved these changes Aug 1, 2024
View reviewed changes
README.md
</dependency>

```

*or if you're using Gradle:*

```bash
implementation 'com.rudderstack.sdk.java.analytics:analytics:3.1.0'
implementation 'com.rudderstack.sdk.java.analytics:analytics:x.y.z'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@1abhishekpandey 1abhishekpandey marked this pull request as draft August 1, 2024 16:35
@1abhishekpandey
chore: make snapshot release
f19626b
@1abhishekpandey
[maven-release-plugin] prepare release analytics-parent-3.1.2
08b23d8
@1abhishekpandey
Revert "chore: make snapshot release"
6ac77d6 
This reverts commit f19626b.
@1abhishekpandey
Revert "[maven-release-plugin] prepare release analytics-parent-3.1.2"
f4f1a85 
This reverts commit 08b23d8.
@1abhishekpandey
fix: revert java to v8
a4a9f90 
This also reverts previous MessageInterceptor java changes.
@1abhishekpandey
Revert "fix: revert java to v8"
a978662 
This reverts commit a4a9f90.
@1abhishekpandey
fix: revert java to v8
a020d80 
This also reverts previous MessageInterceptor java changes.
@1abhishekpandey
chore: address snyk issue
cff5546 
Remove "analytics-spring-boot-starter". This doesn't seems to be utilised.
@1abhishekpandey
ci: change sonar analysis action
dc41d59
@1abhishekpandey
Revert "ci: change sonar analysis action"
b295874 
This reverts commit dc41d59.
@1abhishekpandey
chore: update sonar-maven-plugin version to 4.0.0.4121
d48281d
@1abhishekpandey
chore: set java version 11 for sonar
de59a31
@1abhishekpandey
chore: update sonar-maven-plugin version to 3.7.0.1746
4d55b5a
@1abhishekpandey
fix: release all Java modules with version 3.1.2
81e1bed
@1abhishekpandey
chore: revert the sonar action name
ce4a891
@1abhishekpandey 1abhishekpandey changed the title fix: release all Java modules with version 3.1.1 fix: release all Java modules with version 3.1.2 Aug 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@1abhishekpandey 1abhishekpandey marked this pull request as ready for review August 1, 2024 20:25
@1abhishekpandey 1abhishekpandey merged commit 4b6ae71 into develop Aug 2, 2024
7 checks passed
@1abhishekpandey 1abhishekpandey deleted the feature/sdk-2226-release-other-java-modules branch August 2, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

Assignees

@1abhishekpandey 1abhishekpandey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1abhishekpandey @ChryssaAliferi @saikumarrs