-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(INT-261): refactor ga4 device mode #1185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-js into feat/ga4-debug-view
…-js into feat/ga4-v2
…-js into feat/ga4-v2
mihir-4116
requested review from
ItsSudip,
shrouti1507,
sandeepdsvs,
MoumitaM and
bardisg
as code owners
June 26, 2023 11:09
size-limit report 📦
|
…-js into feat/ga4-v2
saikumarrs
requested changes
Jul 19, 2023
saikumarrs
reviewed
Jul 20, 2023
saikumarrs
previously approved these changes
Aug 18, 2023
mihir-4116
changed the title
chore: refactor ga4 device mode
chore(INT-123): refactor ga4 device mode
Aug 18, 2023
INT-123 GA4 docs inconsistency between Device mode and cloud mode
Hi Team,
|
mihir-4116
changed the title
chore(INT-123): refactor ga4 device mode
chore(INT-261): refactor ga4 device mode
Aug 18, 2023
Details are explained well @mihir-4116, Good job |
saikumarrs
previously approved these changes
Aug 18, 2023
utsabc
previously approved these changes
Aug 21, 2023
shrouti1507
reviewed
Aug 21, 2023
Kudos, SonarCloud Quality Gate passed! |
Increased browser file coverage from 43% to 83% |
shrouti1507
approved these changes
Aug 22, 2023
utsabc
approved these changes
Aug 22, 2023
saikumarrs
approved these changes
Aug 22, 2023
MoumitaM
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request implements a comprehensive refactor of the GA4 integration. The refactoring follows the same approach as the GA4 Cloud Mode flow. All the changes made in this pull request are backward compatible.
Key highlights of this pull request include:
getValueFromMessage
: Retrieves a value from the message payload.handleMetadataForValue
: Handles metadata for a specific value.formatValues
: Formats the values to prepare integration payload in a common utility file.handleSourceKeysOperation
: Handles the operation on source keys.constructPayload
: Modified to prepare the GA4 integration payload, incorporating the newly introduced functions.The capturePageView option is no longer required in the identify call.
Please refer to the Cloud Mode GA4 integration track call flow for a better understanding of the changes in device mode
track calls.
Additionally, this pull request includes:
These changes improve the overall structure, performance, and maintainability of the GA4 integration codebase while
ensuring compatibility with existing functionality.
Notion ticket
Ticket link
Screenshots
Please add screenshots for any new features or UI bug fixes for the following browsers -
Security