fix: only close response body in oauth handler in case of no error (#…

…2593)
rudderlabs · Oct 19, 2022 · 83ace48 · 83ace48
1 parent 09dba21
commit 83ace48
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/router/oauthResponseHandler/oauthResponseHandler.go b/router/oauthResponseHandler/oauthResponseHandler.go
@@ -484,14 +484,14 @@ func (authErrHandler *OAuthErrResHandler) cpApiCall(cpReq *ControlPlaneRequestT)
 		"requestType": cpReq.RequestType,
 	}).SendTiming(time.Since(cpApiDoTimeStart))
 	authErrHandler.logger.Debugf("[%s request] :: destination request sent\n", loggerNm)
-	if res.Body != nil {
-		defer res.Body.Close()
-	}
 	if doErr != nil {
 		// Abort on receiving an error
 		authErrHandler.logger.Errorf("[%s request] :: destination request failed: %+v\n", loggerNm, doErr)
 		return http.StatusBadRequest, doErr.Error()
 	}
+	if res.Body != nil {
+		defer res.Body.Close()
+	}
 	statusCode, resp := processResponse(res)
 	return statusCode, resp
 }