chore: upgrade go to 1.23.0 (#5052)

.github/workflows/verify.yml

@@ -77,5 +77,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v6
         with:
-          version: v1.57.1
+          version: v1.60.3
           args: -v

Dockerfile

@@ -2,7 +2,7 @@
 # syntax=docker/dockerfile:1
 
 # GO_VERSION is updated automatically to match go.mod, see Makefile
-ARG GO_VERSION=1.22.5
+ARG GO_VERSION=1.23.0
 ARG ALPINE_VERSION=3.20
 FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS builder
 ARG VERSION

Makefile

@@ -6,7 +6,7 @@ TESTFILE=_testok
 MOUNT_PATH=/local
 
 # go tools versions
-GOLANGCI=github.com/golangci/golangci-lint/cmd/golangci-lint@v1.57.1
+GOLANGCI=github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3
 gofumpt=mvdan.cc/gofumpt@latest
 govulncheck=golang.org/x/vuln/cmd/govulncheck@latest
 goimports=golang.org/x/tools/cmd/goimports@latest

cmd/rudder-cli/status/status.go

@@ -100,16 +100,16 @@ func GetArgs(request string) error {
 	if request == "Jobs between JobID's of a User" {
 		fmt.Printf("Enter DS Type:")
 		var table string
-		fmt.Scanf("%s", &table)
+		_, _ = fmt.Scanf("%s", &table)
 		fmt.Print("Enter JobID 1: ")
 		var input string
-		fmt.Scanf("%s", &input)
+		_, _ = fmt.Scanf("%s", &input)
 		fmt.Print("Enter JobID 2: ")
 		var input2 string
-		fmt.Scanf("%s", &input2)
+		_, _ = fmt.Scanf("%s", &input2)
 		fmt.Printf("Enter UserID:")
 		var input3 string
-		fmt.Scanf("%s", &input3)
+		_, _ = fmt.Scanf("%s", &input3)
 		argString := table + ":" + request + ":" + input + ":" + input2 + ":" + input3
 		var reply string
 		err := client.GetUDSClient().Call("JobsdbUtilsHandler.RunSQLQuery", argString, &reply)
@@ -120,10 +120,10 @@ func GetArgs(request string) error {
 	} else if request == "Error Code Count By Destination" {
 		fmt.Printf("Enter DS Type:")
 		var table string
-		fmt.Scanf("%s", &table)
+		_, _ = fmt.Scanf("%s", &table)
 		fmt.Print("Enter DS Number: ")
 		var dsNum string
-		fmt.Scanf("%s", &dsNum)
+		_, _ = fmt.Scanf("%s", &dsNum)
 		argString := table + ":" + request + ":" + dsNum
 		var reply string
 		err := client.GetUDSClient().Call("JobsdbUtilsHandler.RunSQLQuery", argString, &reply)

go.mod

@@ -1,6 +1,6 @@
 module github.com/rudderlabs/rudder-server
 
-go 1.22.5
+go 1.23.0
 
 // Addressing snyk vulnerabilities in indirect dependencies
 // When upgrading a dependency, please make sure that

regulation-worker/internal/client/client_test.go

@@ -106,7 +106,7 @@ func TestGet(t *testing.T) {
 				path := r.URL.Path
 				require.Equal(t, tt.expectedPath, path)
 				time.Sleep(time.Duration(tt.serverDelay) * time.Millisecond)
-				fmt.Fprintf(w, tt.respBody)
+				_, _ = w.Write([]byte(tt.respBody))
 			}))
 			defer svr.Close()
 			httpClient := &http.Client{}

regulation-worker/internal/delete/api/api.go

@@ -273,7 +273,7 @@ func (m *APIManager) inactivateAuthStatus(destination *model.Destination, job mo
 		AuthStatus:      oauth.AuthStatusInactive,
 	})
 	jobStatus.Status = model.JobStatusAborted
-	jobStatus.Error = fmt.Errorf(resp)
+	jobStatus.Error = errors.New(resp)
 	return jobStatus
 }
 
@@ -289,7 +289,7 @@ func (m *APIManager) refreshOAuthToken(destination *model.Destination, job model
 		if refreshResponse.Err == oauth.REF_TOKEN_INVALID_GRANT {
 			// authStatus should be made inactive
 			m.inactivateAuthStatus(destination, job, oAuthDetail)
-			return fmt.Errorf(refreshResponse.ErrorMessage)
+			return errors.New(refreshResponse.ErrorMessage)
 		}
 
 		var refreshRespErr string
@@ -350,7 +350,7 @@ func (m *APIManager) PostResponse(ctx context.Context, params PostResponseParams
 		}
 		if authErrorCategory == common.CategoryAuthStatusInactive {
 			// Abort the regulation request
-			return model.JobStatus{Status: model.JobStatusAborted, Error: fmt.Errorf(string(params.responseBodyBytes))}
+			return model.JobStatus{Status: model.JobStatusAborted, Error: errors.New(string(params.responseBodyBytes))}
 		}
 	}
 	return jobStatus

regulation-worker/internal/delete/api/api_test.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"net/http"
 	"net/http/httptest"
@@ -711,8 +712,8 @@ var oauthTests = []oauthTestCases{
 				Response: `{"message": "AuthStatus toggle skipped as already request in-progress: (1234, 1001)"}`,
 			},
 		},
-		expectedDeleteStatus:         model.JobStatus{Status: model.JobStatusAborted, Error: fmt.Errorf("problem with user permission or access/refresh token have been revoked")},
-		expectedDeleteStatus_OAuthV2: model.JobStatus{Status: model.JobStatusAborted, Error: fmt.Errorf(fmt.Sprintf(`[{"status":"failed","authErrorCategory": "%v", "error": "User does not have sufficient permissions"}]`, common.CategoryAuthStatusInactive))},
+		expectedDeleteStatus:         model.JobStatus{Status: model.JobStatusAborted, Error: errors.New("problem with user permission or access/refresh token have been revoked")},
+		expectedDeleteStatus_OAuthV2: model.JobStatus{Status: model.JobStatusAborted, Error: fmt.Errorf(`[{"status":"failed","authErrorCategory": "%v", "error": "User does not have sufficient permissions"}]`, common.CategoryAuthStatusInactive)},
 		expectedPayload:              `[{"jobId":"16","destType":"ga","config":{"authStatus":"active","rudderDeleteAccountId":"xyz"},"userAttributes":[{"email":"greymore@gmail.com","phone":"8463633841","userId":"203984798476"}]}]`,
 	},
 	{

router/batchrouter/asyncdestinationmanager/bing-ads/offline-conversions/bingads_test.go

@@ -3,6 +3,7 @@ package offline_conversions
 import (
 	"archive/zip"
 	stdjson "encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -137,9 +138,9 @@ var _ = Describe("Bing ads Offline Conversions", func() {
 			clientI := Client{}
 			bulkUploader := NewBingAdsBulkUploader("BING_ADS", bingAdsService, &clientI)
 			errorMsg := "Error in getting bulk upload url"
-			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, fmt.Errorf(errorMsg))
-			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, fmt.Errorf(errorMsg))
-			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, fmt.Errorf(errorMsg))
+			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, errors.New(errorMsg))
+			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, errors.New(errorMsg))
+			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, errors.New(errorMsg))
 
 			asyncDestination := common.AsyncDestinationStruct{
 				ImportingJobIDs: []int64{1, 2, 3, 4, 5, 6},
@@ -180,11 +181,11 @@ var _ = Describe("Bing ads Offline Conversions", func() {
 			ClientI := Client{}
 			bulkUploader := NewBingAdsBulkUploader("BING_ADS", bingAdsService, &ClientI)
 			errMsg := "unable to get bulk upload url, check your credentials"
-			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, fmt.Errorf(errMsg))
+			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, errors.New(errMsg))
 
-			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, fmt.Errorf(errMsg))
+			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, errors.New(errMsg))
 
-			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, fmt.Errorf(errMsg))
+			bingAdsService.EXPECT().GetBulkUploadUrl().Return(nil, errors.New(errMsg))
 
 			asyncDestination := common.AsyncDestinationStruct{
 				ImportingJobIDs: []int64{1, 2, 3, 4, 5, 6},

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

@@ -3,6 +3,7 @@ package klaviyobulkupload
 import (
 	"bufio"
 	"bytes"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -375,7 +376,7 @@ func (kbu *KlaviyoBulkUploader) Upload(asyncDestStruct *common.AsyncDestinationS
 
 		if resp.StatusCode != 202 {
 			failedJobs = append(failedJobs, importingJobIDs[idx])
-			kbu.logger.Error("Got non 202 as statusCode.", fmt.Errorf(string(bodyBytes)))
+			kbu.logger.Error("Got non 202 as statusCode.", errors.New(string(bodyBytes)))
 		}
 		var uploadresp UploadResp
 		uploadRespErr := json.Unmarshal((bodyBytes), &uploadresp)

router/batchrouter/asyncdestinationmanager/yandexmetrica/yandexmetrica.go

@@ -3,6 +3,7 @@ package yandexmetrica
 import (
 	"bytes"
 	"encoding/csv"
+	"errors"
 	"fmt"
 	"io"
 	"mime/multipart"
@@ -361,7 +362,7 @@ func (ym *YandexMetricaBulkUploader) Upload(asyncDestStruct *common.AsyncDestina
 	uploadTimeStat.Since(startTime)
 
 	if resp.StatusCode != http.StatusOK { // error scenario
-		return ym.generateErrorOutput("got non 200 response from the destination", fmt.Errorf(string(bodyBytes)), importingJobIDs)
+		return ym.generateErrorOutput("got non 200 response from the destination", errors.New(string(bodyBytes)), importingJobIDs)
 	}
 	eventsSuccessStat.Count(len(asyncDestStruct.ImportingJobIDs))
 	return common.AsyncUploadOutput{

router/transformer/transformer.go

@@ -6,6 +6,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -597,7 +598,7 @@ func (trans *handle) doProxyRequest(ctx context.Context, proxyUrl string, proxyR
 		return httpProxyResponse{
 			respData:   []byte{},
 			statusCode: http.StatusInternalServerError,
-			err:        fmt.Errorf(errStr),
+			err:        errors.New(errStr),
 		}
 	}
 

services/streammanager/bqstream/bqstreammanager.go

@@ -156,5 +156,5 @@ func (producer *BQStreamProducer) Close() error {
 func createErr(err error, msg string) error {
 	fmtMsg := fmt.Errorf("[BQStream] error :: %v:: %w", msg, err).Error()
 	pkgLogger.Errorf(fmtMsg)
-	return fmt.Errorf(fmtMsg)
+	return errors.New(fmtMsg)
 }

suppression-backup-service/Dockerfile

@@ -1,7 +1,7 @@
 # syntax=docker/dockerfile:1
 
 # GO_VERSION is updated automatically to match go.mod, see Makefile
-ARG GO_VERSION=1.22.5
+ARG GO_VERSION=1.23.0
 ARG ALPINE_VERSION=3.20
 FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS builder
 RUN mkdir /app

warehouse/integrations/postgres/postgres.go

@@ -496,7 +496,7 @@ func (pg *Postgres) Connect(_ context.Context, warehouse model.Warehouse) (clien
 	if warehouse.Destination.Config["sslMode"] == "verify-ca" {
 		if err := warehouseutils.WriteSSLKeys(warehouse.Destination); err.IsError() {
 			pg.logger.Error(err.Error())
-			return client.Client{}, fmt.Errorf(err.Error())
+			return client.Client{}, errors.New(err.Error())
 		}
 	}
 	pg.Warehouse = warehouse

warehouse/internal/loadfiles/loadfiles.go

@@ -3,6 +3,7 @@ package loadfiles
 import (
 	"context"
 	stdjson "encoding/json"
+	"errors"
 	"fmt"
 	"slices"
 	"strings"
@@ -291,7 +292,7 @@ func (lf *LoadFileGenerator) createFromStaging(ctx context.Context, job *model.U
 
 				if resp.Status == notifier.Aborted && resp.Error != nil {
 					lf.Logger.Errorf("[WH]: Error in generating load files: %v", resp.Error)
-					sampleError = fmt.Errorf(resp.Error.Error())
+					sampleError = errors.New(resp.Error.Error())
 					err = lf.StageRepo.SetErrorStatus(ctx, jobResponse.StagingFileID, sampleError)
 					if err != nil {
 						return fmt.Errorf("set staging file error status: %w", err)

warehouse/utils/utils_test.go

@@ -817,7 +817,7 @@ func TestObjectStorageType(t *testing.T) {
 }
 
 func TestGetTablePathInObjectStorage(t *testing.T) {
-	require.NoError(t, os.Setenv("WAREHOUSE_DATALAKE_FOLDER_NAME", "rudder-test-payload"))
+	t.Setenv("WAREHOUSE_DATALAKE_FOLDER_NAME", "rudder-test-payload")
 	inputs := []struct {
 		namespace string
 		tableName string

warehouse/validations/validate.go

@@ -552,8 +552,10 @@ type dummyUploader struct {
 	dest *backendconfig.DestinationT
 }
 
-func (*dummyUploader) IsWarehouseSchemaEmpty() bool                          { return true }
-func (*dummyUploader) GetLocalSchema(context.Context) (model.Schema, error)  { return nil, nil }
+func (*dummyUploader) IsWarehouseSchemaEmpty() bool { return true }
+func (*dummyUploader) GetLocalSchema(context.Context) (model.Schema, error) {
+	return model.Schema{}, nil
+}
 func (*dummyUploader) UpdateLocalSchema(context.Context, model.Schema) error { return nil }
 func (*dummyUploader) ShouldOnDedupUseNewRecord() bool                       { return false }
 func (*dummyUploader) GetFirstLastEvent() (time.Time, time.Time)             { return time.Time{}, time.Time{} }