Merge branch 'master' into feat.onboard.bingads.offline.conversions

rudderlabs · May 20, 2024 · 9556f34 · 9556f34
2 parents 1284dc0 + 5090a8d
commit 9556f34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go b/router/batchrouter/asyncdestinationmanager/marketo-bulk-upload/marketobulkupload.go
@@ -80,6 +80,7 @@ func (b *MarketoBulkUploader) Poll(pollInput common.AsyncPoll) common.PollStatus
 		return common.PollStatusResponse{
 			StatusCode: transformerConnectionStatus,
 			HasFailed:  true,
+			Error:      string(bodyBytes),
 		}
 	}
 	var asyncResponse common.PollStatusResponse

diff --git a/router/batchrouter/handle_async.go b/router/batchrouter/handle_async.go
@@ -258,7 +258,7 @@ func (brt *Handle) updatePollStatusToDB(
 		brt.asyncAbortedJobCount.Count(len(statusList))
 	} else {
 		var abortedJobsList []*jobsdb.JobT
-		statusList, abortedJobsList, jobIDConnectionDetailsMap = brt.prepareJobStatusList(importingList, jobsdb.JobStatusT{JobState: jobsdb.Failed.State, ErrorResponse: misc.UpdateJSONWithNewKeyVal(routerutils.EmptyPayload, "error", pollResp.Error)}, sourceID, destinationID)
+		statusList, abortedJobsList, jobIDConnectionDetailsMap = brt.prepareJobStatusList(importingList, jobsdb.JobStatusT{JobState: jobsdb.Failed.State, ErrorCode: strconv.Itoa(pollResp.StatusCode), ErrorResponse: misc.UpdateJSONWithNewKeyVal(routerutils.EmptyPayload, "error", pollResp.Error)}, sourceID, destinationID)
 		if err := brt.updateJobStatuses(ctx, destinationID, importingList, abortedJobsList, statusList); err != nil {
 			brt.logger.Errorf("[Batch Router] Failed to update job status for Dest Type %v with error %v", brt.destType, err)
 			return statusList, err