-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed query to accept user input in prepared sql statement #2652
Conversation
Codecov ReportBase: 43.74% // Head: 43.76% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
+ Coverage 43.74% 43.76% +0.02%
==========================================
Files 187 187
Lines 39993 39999 +6
==========================================
+ Hits 17494 17505 +11
+ Misses 21403 21395 -8
- Partials 1096 1099 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
warehouseutils.WarehouseUploadsTable, | ||
sourceOrDestId, | ||
sourceOrDestColumn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we need to use pq.QuoteIdentifier
for table/column names as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for the said variable. Doing it for the whole code will take time. Should we do it after as soon as get some bandwidth? Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's discuss further refactoring and prioritise accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With some minor comments
Description
Github reported few vulnerability. Mentioning the slack conversation:
https://rudderlabs.slack.com/archives/C049T5P2Z97/p1667507291386099
Notion Ticket
https://www.notion.so/rudderstacks/SQL-injection-vulnerability-in-TriggerWHUploads-rudder-server-25b7e45711034ad7889f458ad24768b0
Security