chore: get processor namespace, instanceID during setup

[Sidddddarth]

Description

Instead of config.Get...ing the same thing(kube namespace, instanceID) for every event, we may fetch it once and use that information for all.

Linear Ticket

Resolves PIPE-1072

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[coderabbitai]

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Tip

Early Access Features

• gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.80%. Comparing base (51e3e4e) to head (7387e1c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4718      +/-   ##
==========================================
+ Coverage   74.60%   74.80%   +0.19%     
==========================================
  Files         414      414              
  Lines       48546    48548       +2     
==========================================
+ Hits        36220    36315      +95     
+ Misses       9954     9880      -74     
+ Partials     2372     2353      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lvrach]

What's the difference in benchmark? Although in isolation isolation rlocks won't have much impact

[Sidddddarth]

This was added a couple years ago. When we changed some json parsing logic inside. No intention to benchmark anything now.

[lvrach]

just out of curiosity, is there any observable difference if you run the same benchmark before and after the change?

[Sidddddarth]

current PR:

goos: darwin
goarch: arm64
pkg: github.com/rudderlabs/rudder-server/processor
Benchmark_makeCommonMetadataFromSingularEvent-10    	 3478596	       335.6 ns/op	     544 B/op	       2 allocs/op
PASS
ok  	github.com/rudderlabs/rudder-server/processor	4.636s

master:

goos: darwin
goarch: arm64
pkg: github.com/rudderlabs/rudder-server/processor
Benchmark_makeCommonMetadataFromSingularEvent-10    	 1794634	       655.5 ns/op	     640 B/op	       8 allocs/op
PASS
ok  	github.com/rudderlabs/rudder-server/processor	4.750s