Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboard new custom destination: wunderkind #4798
feat: onboard new custom destination: wunderkind #4798
Changes from all commits
ca30c5f
1b811d2
131c445
2a9d324
706468e
b7ce9d3
58a38ea
b0991d6
195ebcd
04def6b
ce4548e
557c5dd
b408234
c71f896
4bc22cb
1519910
74dfca2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 56 in services/streammanager/streammanager.go
Codecov / codecov/patch
services/streammanager/streammanager.go#L54-L56
Check warning on line 87 in services/streammanager/wunderkind/wunderkindmanager.go
Codecov / codecov/patch
services/streammanager/wunderkind/wunderkindmanager.go#L87
Check warning on line 121 in services/streammanager/wunderkind/wunderkindmanager.go
Codecov / codecov/patch
services/streammanager/wunderkind/wunderkindmanager.go#L121
Check warning on line 125 in services/streammanager/wunderkind/wunderkindmanager.go
Codecov / codecov/patch
services/streammanager/wunderkind/wunderkindmanager.go#L125
Check warning on line 133 in services/streammanager/wunderkind/wunderkindmanager.go
Codecov / codecov/patch
services/streammanager/wunderkind/wunderkindmanager.go#L133
Check warning on line 139 in services/streammanager/wunderkind/wunderkindmanager.go
Codecov / codecov/patch
services/streammanager/wunderkind/wunderkindmanager.go#L139
Check warning on line 141 in services/streammanager/wunderkind/wunderkindmanager.go
Codecov / codecov/patch
services/streammanager/wunderkind/wunderkindmanager.go#L141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use mem logger instead, much more maintainable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you referring about this?
https://pkg.go.dev/go.chromium.org/luci/common/logging/memlogger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lvrach We don't have mem logger implementation. But in this particular case, we can simply asssert for returned variables, Don't see much of a value in asserting if we are logging or not?