-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: send connection config to router transform #4903
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Adding @koladilip . He wanted to review the PR. |
@Sidddddarth you will be raising for processor or proxy later? |
430f38c
to
b98d02c
Compare
7d3b843
to
60d2c10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
we tested this @Sidddddarth but not all flows but it is good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with a nitpick
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4903 +/- ##
==========================================
- Coverage 74.83% 74.60% -0.23%
==========================================
Files 436 436
Lines 50385 50427 +42
==========================================
- Hits 37704 37621 -83
- Misses 10211 10315 +104
- Partials 2470 2491 +21 ☔ View full report in Codecov by Sentry. |
Description
Rudder server now sends
connection config
to router transform with each job.Due to this being pertinent only in case of sources jobs, we have a check to drop job only if it's a sources job.
Linear Ticket
Resolves PIPE-1222
Security