-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vaccum handling in error detail reports table #4945
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@@ -90,6 +93,7 @@ type errorDetails struct { | |||
func NewErrorDetailReporter( | |||
ctx context.Context, | |||
configSubscriber *configSubscriber, | |||
stats stats.Stats, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 for injecting stats
@mihir20 is looking for a way to test the vacuuming. You should have a chat. |
Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4945 +/- ##
==========================================
- Coverage 74.40% 74.39% -0.01%
==========================================
Files 428 428
Lines 49885 49909 +24
==========================================
+ Hits 37119 37132 +13
- Misses 10318 10334 +16
+ Partials 2448 2443 -5 ☔ View full report in Codecov by Sentry. |
Description
Fixed vaccumisation of error_detail_reports table incase the table grows too big
Linear Ticket
Resolves INT-2476
Security