Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce max limit for webhook #4975

Merged
merged 1 commit into from
Aug 6, 2024
Merged

chore: enforce max limit for webhook #4975

merged 1 commit into from
Aug 6, 2024

Conversation

achettyiitr
Copy link
Member

Description

  • Max limit enforcement on the incoming webhook request.
  • Currently, we are enforcing the source transformation responses we get from the transformer if there is some Output present.
  • We might overwhelm the transformers if we don't enforce the incoming webhook request.

Linear Ticket

  • Resolves PIPE-1382

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 4, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@achettyiitr achettyiitr force-pushed the chore.enforce-maxlimit-webhook branch from 578bdc5 to fe7e2a1 Compare August 4, 2024 13:12
@codecov Codecov
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (a27b583) to head (fe7e2a1).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4975   +/-   ##
=======================================
  Coverage   74.40%   74.41%           
=======================================
  Files         428      428           
  Lines       49885    49891    +6     
=======================================
+ Hits        37119    37128    +9     
+ Misses      10318    10314    -4     
- Partials     2448     2449    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ktgowtham
ktgowtham approved these changes Aug 6, 2024
View reviewed changes
gateway/webhook/webhook.go
@@ -334,6 +335,13 @@ func (bt *batchWebhookTransformerT) batchTransformLoop() {
req.done <- transformerResponse{Err: response.GetStatus(response.InvalidJSON)}
continue
}
if len(body) > bt.webhook.config.maxReqSize.Load() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How costly is Load function? would it be okay to keep it outside the loop? If it's not costly, should be fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just map lookup. https://github.com/rudderlabs/rudder-go-kit/blob/main/config/hotreloadable.go#L784-L790

@achettyiitr achettyiitr merged commit 377887a into master Aug 6, 2024
53 checks passed
@achettyiitr achettyiitr deleted the chore.enforce-maxlimit-webhook branch August 6, 2024 07:37
This was referenced Aug 16, 2024
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@ktgowtham ktgowtham ktgowtham approved these changes

@lvrach lvrach Awaiting requested review from lvrach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achettyiitr @ktgowtham @koladilip