-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert support for webhook headers #5064
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.33.x #5064 +/- ##
=================================================
Coverage ? 74.59%
=================================================
Files ? 436
Lines ? 50373
Branches ? 0
=================================================
Hits ? 37576
Misses ? 10307
Partials ? 2490 ☔ View full report in Codecov by Sentry. |
* chore: release 1.33.0 (#5047) * fix: revert support for webhook headers (#5064) * fix: revert support for webhook headers * chore: ran go mod tidy * chore: release 1.33.1 (#5065) --------- Co-authored-by: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Co-authored-by: Dilip Kola <33080863+koladilip@users.noreply.github.com>
Description
The webhook headers feature was added in release 1.33 but it is causing issues for SendGrid webhooks as they are sending the request body as a JSON array so we are reverting the change and we will revisit the logic later
Linear Ticket
https://linear.app/rudderstack/issue/INT-2504/webhook-source-deckers-has-requested-the-ability-to-forward-the-x-dash
Security