-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bq configurable partitions #5133
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5133 +/- ##
==========================================
- Coverage 72.94% 72.90% -0.04%
==========================================
Files 438 439 +1
Lines 50896 51109 +213
==========================================
+ Hits 37125 37262 +137
- Misses 11339 11400 +61
- Partials 2432 2447 +15 ☔ View full report in Codecov by Sentry. |
logger.NewStringField("partitionType", partitionType), | ||
) | ||
timePartitioning = &bigquery.TimePartitioning{ | ||
Type: bigquery.DayPartitioningType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the column is not found we fall-back to using _PARTITIONTIME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is just a safety check.
5052ce2
to
dff971c
Compare
dff971c
to
c2a3aaf
Compare
c2a3aaf
to
be498a3
Compare
be498a3
to
e19da86
Compare
Description
loaded_at
,received_at
) for the supported partition types (HOUR
,DAY
) for BigQuery._PARTITIONTIME
) withDAY
level partition is used.Linear Ticket
Security