Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bq configurable partitions #5133

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 23, 2024

Description

  • Added the ability to choose partition columns (loaded_at, received_at) for the supported partition types (HOUR, DAY) for BigQuery.
  • By default, if nothing is specified Ingestion Time (_PARTITIONTIME) with DAY level partition is used.
  • Corresponding UI changes: feat: bq configurable partitions rudder-integrations-config#1630

Linear Ticket

  • Resolves PIPE-1352
  • Resolves PIPE-1421

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 78.97574% with 78 lines in your changes missing coverage. Please review.

Project coverage is 72.90%. Comparing base (e37b0e9) to head (e19da86).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
warehouse/integrations/bigquery/bigquery.go 75.32% 56 Missing and 20 partials ⚠️
warehouse/integrations/bigquery/partition.go 95.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5133      +/-   ##
==========================================
- Coverage   72.94%   72.90%   -0.04%     
==========================================
  Files         438      439       +1     
  Lines       50896    51109     +213     
==========================================
+ Hits        37125    37262     +137     
- Misses      11339    11400      +61     
- Partials     2432     2447      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

integration_test/warehouse/integration_test.go Outdated Show resolved Hide resolved
logger.NewStringField("partitionType", partitionType),
)
timePartitioning = &bigquery.TimePartitioning{
Type: bigquery.DayPartitioningType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the column is not found we fall-back to using _PARTITIONTIME

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is just a safety check.

@achettyiitr achettyiitr force-pushed the feat.bq-configurable-partitions branch 3 times, most recently from 5052ce2 to dff971c Compare September 27, 2024 12:33
@achettyiitr achettyiitr merged commit 9544374 into master Sep 30, 2024
56 checks passed
@achettyiitr achettyiitr deleted the feat.bq-configurable-partitions branch September 30, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants