Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimise config backend revisionId calls #5139

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Sep 26, 2024

Description

PrizePicks CFD

  • Reduce the number of config backend API calls being made for a single revisionId
  • VACUUM FULL notifier table if the size exceeds 5GB

Linear Ticket

Fixes PIPE-1583

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 73.04%. Comparing base (f835aa7) to head (03fecd7).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
services/notifier/repo.go 44.44% 3 Missing and 2 partials ⚠️
warehouse/internal/loadfiles/loadfiles.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5139      +/-   ##
==========================================
- Coverage   73.11%   73.04%   -0.07%     
==========================================
  Files         437      438       +1     
  Lines       50789    50907     +118     
==========================================
+ Hits        37134    37185      +51     
- Misses      11228    11292      +64     
- Partials     2427     2430       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 marked this pull request as ready for review September 30, 2024 06:32
@cisse21 cisse21 changed the title chore: debug logs chore: optimise config backend revisionId calls Sep 30, 2024
@cisse21 cisse21 merged commit 62143dc into master Sep 30, 2024
58 checks passed
@cisse21 cisse21 deleted the chore.debuglogs branch September 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants