Move KibanaMigrator into Server SavedObjectsService (elastic#43433)

* Rename SavedObjectsService -> SavedObjectsLegacyService * Expose legacy pluginSpecs from Core LegacyService * Expose legacy uiExports from Core LegacyService * Move kibana config to NP * Expose pluginExtendedConfig from LegacyService * Make KibanaMigrator NP compatible * KibanaMigrator -> NP SavedObjectsService * SavedObjectsService never stop retrying ES connection error * Move waiting for migrations to complete till after legacy service start * Fix ESArchiver's KibanaMigrator * Fix reload logging config tests * Run migrations on savedobjects start * Fix env tests * Fix and make legacy tests more robust/isolated * Cleanup code * Fix invalid config test * Fix SavedObject Migrations logging test * SavedObjectsService tests * Lifecycle logging and improve getting kibanaConfig instance * Fix awaitMigration bug and test * Fix typing error * Review comments * Remove unecessary KibanaConfig class * Move legacy plugin config extension, specs, uiExports entirely into Core uiExports, specs, disabledSpecs, config now get injected into KbnServer * Fix config deprecation test * Use existing logger mock * Create SavedObjectsConfig for migration config * Define KibanaMigratorContract type * KibanaMigratorContract -> IKibanaMigrator + docs improvements * Fix esArchiver's KibanaMigrator * Fix plugin generator integration test * ConfigServiceContract -> IConfigService * Address review comments * Review nits * Document migrations.skip config * Review comments continued... * awaitMigrations -> runMigrations * Type improvements
rudolf · Oct 1, 2019 · 3722798 · 3722798
1 parent 813dbbd
commit 3722798
Show file tree

Hide file tree

Showing 106 changed files with 1,400 additions and 1,115 deletions.
diff --git a/docs/development/core/server/kibana-plugin-server.internalcorestart.md b/docs/development/core/server/kibana-plugin-server.internalcorestart.md
diff --git a/docs/development/core/server/kibana-plugin-server.md b/docs/development/core/server/kibana-plugin-server.md
@@ -21,8 +21,6 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 |  [ElasticsearchErrorHelpers](./kibana-plugin-server.elasticsearcherrorhelpers.md) | Helpers for working with errors returned from the Elasticsearch service.Since the internal data of errors are subject to change, consumers of the Elasticsearch service should always use these helpers to classify errors instead of checking error internals such as <code>body.error.header[WWW-Authenticate]</code> |
 |  [KibanaRequest](./kibana-plugin-server.kibanarequest.md) | Kibana specific abstraction for an incoming request. |
 |  [SavedObjectsErrorHelpers](./kibana-plugin-server.savedobjectserrorhelpers.md) |  |
-|  [SavedObjectsSchema](./kibana-plugin-server.savedobjectsschema.md) |  |
-|  [SavedObjectsSerializer](./kibana-plugin-server.savedobjectsserializer.md) |  |
 |  [ScopedClusterClient](./kibana-plugin-server.scopedclusterclient.md) | Serves the same purpose as "normal" <code>ClusterClient</code> but exposes additional <code>callAsCurrentUser</code> method that doesn't use credentials of the Kibana internal user (as <code>callAsInternalUser</code> does) to request Elasticsearch API, but rather passes HTTP headers extracted from the current user request to the API |
 
 ## Enumerations
@@ -52,7 +50,6 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 |  [HttpServiceStart](./kibana-plugin-server.httpservicestart.md) |  |
 |  [IContextContainer](./kibana-plugin-server.icontextcontainer.md) | An object that handles registration of context providers and configuring handlers with context. |
 |  [IKibanaSocket](./kibana-plugin-server.ikibanasocket.md) | A tiny abstraction for TCP socket. |
-|  [InternalCoreStart](./kibana-plugin-server.internalcorestart.md) |  |
 |  [IRouter](./kibana-plugin-server.irouter.md) | Registers route handlers for specified resource path and method. |
 |  [KibanaRequestRoute](./kibana-plugin-server.kibanarequestroute.md) | Request specific route information exposed to a handler. |
 |  [LegacyRequest](./kibana-plugin-server.legacyrequest.md) |  |
@@ -96,7 +93,6 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 |  [SavedObjectsMigrationVersion](./kibana-plugin-server.savedobjectsmigrationversion.md) | Information about the migrations that have been applied to this SavedObject. When Kibana starts up, KibanaMigrator detects outdated documents and migrates them based on this value. For each migration that has been applied, the plugin's name is used as a key and the latest migration version as the value. |
 |  [SavedObjectsRawDoc](./kibana-plugin-server.savedobjectsrawdoc.md) | A raw document as represented directly in the saved object index. |
 |  [SavedObjectsResolveImportErrorsOptions](./kibana-plugin-server.savedobjectsresolveimporterrorsoptions.md) | Options to control the "resolve import" operation. |
-|  [SavedObjectsService](./kibana-plugin-server.savedobjectsservice.md) |  |
 |  [SavedObjectsUpdateOptions](./kibana-plugin-server.savedobjectsupdateoptions.md) |  |
 |  [SavedObjectsUpdateResponse](./kibana-plugin-server.savedobjectsupdateresponse.md) |  |
 |  [SessionStorage](./kibana-plugin-server.sessionstorage.md) | Provides an interface to store and retrieve data across requests. |

diff --git a/...evelopment/core/server/kibana-plugin-server.savedobjectsschema._constructor_.md b/...evelopment/core/server/kibana-plugin-server.savedobjectsschema._constructor_.md
diff --git a/.../core/server/kibana-plugin-server.savedobjectsschema.getconverttoaliasscript.md b/.../core/server/kibana-plugin-server.savedobjectsschema.getconverttoaliasscript.md
diff --git a/...elopment/core/server/kibana-plugin-server.savedobjectsschema.getindexfortype.md b/...elopment/core/server/kibana-plugin-server.savedobjectsschema.getindexfortype.md
diff --git a/...development/core/server/kibana-plugin-server.savedobjectsschema.ishiddentype.md b/...development/core/server/kibana-plugin-server.savedobjectsschema.ishiddentype.md
diff --git a/...ment/core/server/kibana-plugin-server.savedobjectsschema.isnamespaceagnostic.md b/...ment/core/server/kibana-plugin-server.savedobjectsschema.isnamespaceagnostic.md
diff --git a/docs/development/core/server/kibana-plugin-server.savedobjectsschema.md b/docs/development/core/server/kibana-plugin-server.savedobjectsschema.md
diff --git a/...opment/core/server/kibana-plugin-server.savedobjectsserializer._constructor_.md b/...opment/core/server/kibana-plugin-server.savedobjectsserializer._constructor_.md
diff --git a/...opment/core/server/kibana-plugin-server.savedobjectsserializer.generaterawid.md b/...opment/core/server/kibana-plugin-server.savedobjectsserializer.generaterawid.md
diff --git a/...ent/core/server/kibana-plugin-server.savedobjectsserializer.israwsavedobject.md b/...ent/core/server/kibana-plugin-server.savedobjectsserializer.israwsavedobject.md
diff --git a/docs/development/core/server/kibana-plugin-server.savedobjectsserializer.md b/docs/development/core/server/kibana-plugin-server.savedobjectsserializer.md
diff --git a/...ent/core/server/kibana-plugin-server.savedobjectsserializer.rawtosavedobject.md b/...ent/core/server/kibana-plugin-server.savedobjectsserializer.rawtosavedobject.md
diff --git a/...ent/core/server/kibana-plugin-server.savedobjectsserializer.savedobjecttoraw.md b/...ent/core/server/kibana-plugin-server.savedobjectsserializer.savedobjecttoraw.md
diff --git a/...-plugin-server.savedobjectsservice.addscopedsavedobjectsclientwrapperfactory.md b/...-plugin-server.savedobjectsservice.addscopedsavedobjectsclientwrapperfactory.md
diff --git a/...re/server/kibana-plugin-server.savedobjectsservice.getsavedobjectsrepository.md b/...re/server/kibana-plugin-server.savedobjectsservice.getsavedobjectsrepository.md
diff --git a/.../server/kibana-plugin-server.savedobjectsservice.getscopedsavedobjectsclient.md b/.../server/kibana-plugin-server.savedobjectsservice.getscopedsavedobjectsclient.md
diff --git a/...evelopment/core/server/kibana-plugin-server.savedobjectsservice.importexport.md b/...evelopment/core/server/kibana-plugin-server.savedobjectsservice.importexport.md