Skip to content

Commit

Permalink
ci: Migrate to Windows Server 2022
Browse files Browse the repository at this point in the history
Per actions/runner-images#4856,
`windows-latest` will default to `windows-2022` soon (not later than
March, 6). Since it seems like we still run on `windows-2019`, force the
migration by specifying `windows-2022` explicitly.

Since actions/runner-images#5050 is
merged, this should fix the failing Web tests on mismatched Chrome and
chromedriver versions.

TODO: Once `windows-latest` defaults to `windows-2022` (again, March, 6),
change back to `windows-latest`.
  • Loading branch information
relrelb authored and kmeisthax committed Feb 17, 2022
1 parent 40f356a commit 4037707
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release_nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,12 @@ jobs:
target: aarch64-apple-darwin

- build_name: windows-x86_32
os: windows-latest
os: windows-2022
target: i686-pc-windows-msvc
RUSTFLAGS: -Ctarget-feature=+crt-static

- build_name: windows-x86_64
os: windows-latest
os: windows-2022
target: x86_64-pc-windows-msvc
RUSTFLAGS: -Ctarget-feature=+crt-static

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
fail-fast: false
matrix:
rust_version: [stable]
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-2022, macos-latest]
include:
- rust_version: nightly
os: ubuntu-latest
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
strategy:
matrix:
rust_version: [stable]
os: [ubuntu-latest, windows-latest, macos-latest]
os: [ubuntu-latest, windows-2022, macos-latest]
include:
- rust_version: nightly
os: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_web.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
matrix:
node_version: ["14", "16"]
rust_version: [stable] # We most likely don't care about Rust versions here, we'll catch those issues in test_rust.yml.
os: [ubuntu-latest, windows-latest]
os: [ubuntu-latest, windows-2022]

steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
# We most likely don't care about Rust versions here, we'll catch those issues in test_rust.yml.
rust_version: [stable]
# MIKE: Turning off macOS-latest for now (flaky tests on CI).
os: [ubuntu-latest, windows-latest]
os: [ubuntu-latest, windows-2022]

steps:
- name: No-op
Expand Down

0 comments on commit 4037707

Please sign in to comment.