Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HomestarRunner.com Main Page #24] Blur filter doesn't properly cover the AVM1Buttons #12200

Closed
TheGentleChainsaw opened this issue Jul 21, 2023 · 3 comments · Fixed by #12299
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working filter-effects Issues involving filter effects such as Blur, Glow, etc.

Comments

@TheGentleChainsaw
Copy link

TheGentleChainsaw commented Jul 21, 2023

Describe the bug

This one has long been known as one of the few Ruffle compatibility gaps in old H*R content. Now it's been mostly fixed with the recently-added blur filters, the main joke of the page actually comes across now, but there are still a couple of issues. The main one is that the buttons on the left aren't being blurred at all, even though they would be in Flash Player:
image 1

Also, when trying to play this in an up-to-date web player, the blur effect is... just way off. The detail gets washed out far too much, and the radius of the blur effect gets clipped by what I'm guessing are the outside margins of the original objects underneath: (fixed already, my browser was just using an outdated build)
image 1

Expected behavior

The blur effect should apply to the entire displayed screen and shouldn't be clipped at its edges. For comparison, here's what it looks like in Flash Player:
image
(Ignore the lack of top-bar buttons, those are provided by external SWFs that I can't easily load in Flash Player.)

Affected platform

Browser's extension

Operating system

Windows 10

Browser

Mozilla Firefox 115

Additional information

No response

@TheGentleChainsaw TheGentleChainsaw added the bug Something isn't working label Jul 21, 2023
@Lord-McSweeney
Copy link
Collaborator

That clipping was fixed in a more recent version of Ruffle.
chrome-extension___donbcfbmhbcapadipfkeojnmajbakjdc_player html_url=https%3A%2F%2Fold homestarrunner com%2Fmain24 swf
(web extension page)

@Lord-McSweeney Lord-McSweeney added the filter-effects Issues involving filter effects such as Blur, Glow, etc. label Jul 21, 2023
@n0samu n0samu added the A-avm1 Area: AVM1 (ActionScript 1 & 2) label Jul 21, 2023
@n0samu
Copy link
Member

n0samu commented Jul 21, 2023

This happens because in Ruffle, setting DisplayObject.filters for an AVM1Button does not render the filter. Here is a minimal reproduction of the problem: ButtonFilterAS2.zip
The problem does not occur for AVM2Button or for movie clips.

@TheGentleChainsaw
Copy link
Author

That clipping was fixed in a more recent version of Ruffle. chrome-extension___donbcfbmhbcapadipfkeojnmajbakjdc_player html_url=https%3A%2F%2Fold homestarrunner com%2Fmain24 swf (web extension page)

Yep, consistent with the latest extension build from AMO. Now we just need to sort the buttons out.

@TheGentleChainsaw TheGentleChainsaw changed the title [HomestarRunner.com Main Page #24] Blur filter doesn't work correctly [HomestarRunner.com Main Page #24] Blur filter doesn't properly cover the AVM1 buttons Jul 21, 2023
@TheGentleChainsaw TheGentleChainsaw changed the title [HomestarRunner.com Main Page #24] Blur filter doesn't properly cover the AVM1 buttons [HomestarRunner.com Main Page #24] Blur filter doesn't properly cover the AVM1Buttons Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working filter-effects Issues involving filter effects such as Blur, Glow, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants