Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avm1: Implement Button.filters #12299

Merged
merged 1 commit into from
Jul 25, 2023
Merged

avm1: Implement Button.filters #12299

merged 1 commit into from
Jul 25, 2023

Conversation

Lord-McSweeney
Copy link
Collaborator

Fixes #12200.

Dinnerbone
Dinnerbone approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably a lot of stuff we need to copy from movieclip over :(

@Lord-McSweeney
Copy link
Collaborator Author

For our current impl, only cacheAsBitmap needs to be added to Button.

@Dinnerbone Dinnerbone merged commit 38b4357 into ruffle-rs:master Jul 25, 2023
@Lord-McSweeney Lord-McSweeney deleted the patch-2 branch July 25, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinnerbone Dinnerbone Dinnerbone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HomestarRunner.com Main Page #24] Blur filter doesn't properly cover the AVM1Buttons
2 participants
@Lord-McSweeney @Dinnerbone