Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insane Orb - Initial Background Gradient Incorrect #1415

Closed
BlueMaxima opened this issue Oct 28, 2020 · 2 comments
Closed

Insane Orb - Initial Background Gradient Incorrect #1415

BlueMaxima opened this issue Oct 28, 2020 · 2 comments
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working

Comments

@BlueMaxima
Copy link

image

The right side is ruffle.rs, the left is the Adobe Flash projector, showing the background gradient is incorrect.
@Herschel Herschel mentioned this issue Nov 6, 2020
Closed
@Herschel Herschel mentioned this issue Oct 17, 2021
Closed
4 tasks
Herschel added a commit to Herschel/ruffle that referenced this issue Oct 17, 2021
@Herschel
avm1: Reference display objects indirectly by string path
ea06521 
AVM1 display objects do not actually hold pointers to their display
object, but instead refer to them indirectly via string path (for
example, `_level0.clip.foo`).

This means:
 * Every property access on an AVM1 display object requires
   re-resolving the path to the actual object.
 * If that display object is removed from the stage, the AVM1 object
   still exists, but the the path no longer resolves to a display
   object, so the reference is "dangling". Any operations on the
   AVM1 object are noops.
 * If a display object with the same path is later added to the
   stage, the AVM1 object will once again resolve, and all
   operations will work using the new display object.

Fixes ruffle-rs#993, ruffle-rs#1415, ruffle-rs#1513, ...
CUB3D pushed a commit to CUB3D/ruffle that referenced this issue Dec 31, 2022
@Herschel @CUB3D
avm1: Reference display objects indirectly by string path
04b5ac7 
AVM1 display objects do not actually hold pointers to their display
object, but instead refer to them indirectly via string path (for
example, `_level0.clip.foo`).

This means:
 * Every property access on an AVM1 display object requires
   re-resolving the path to the actual object.
 * If that display object is removed from the stage, the AVM1 object
   still exists, but the the path no longer resolves to a display
   object, so the reference is "dangling". Any operations on the
   AVM1 object are noops.
 * If a display object with the same path is later added to the
   stage, the AVM1 object will once again resolve, and all
   operations will work using the new display object.

Fixes ruffle-rs#993, ruffle-rs#1415, ruffle-rs#1513, ...
@Lord-McSweeney
Copy link
Collaborator

Lord-McSweeney commented Jan 16, 2023 •
edited
Loading

The background is now correct on the first gamemode (gravity/anti-gravity orb), but not on the second.

@n0samu
Copy link
Member

n0samu commented Apr 30, 2023

I just played through the game for a bit and the first and second backgrounds both seem to match Flash Player. So I think this bug is fixed, but please leave a comment if anything is still incorrect and I can reopen the issue.

@n0samu n0samu closed this as completed Apr 30, 2023
@n0samu n0samu added bug Something isn't working A-avm1 Area: AVM1 (ActionScript 1 & 2) labels Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BlueMaxima @n0samu @Lord-McSweeney