Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic screen sometimes does not appear when it should on the extension's SWF player page #14665

Closed
n0samu opened this issue Jan 8, 2024 · 0 comments
Labels
A-web Area: Web & Extensions bug Something isn't working extension Related to the Ruffle WebExtension

Comments

@n0samu
Copy link
Member

n0samu commented Jan 8, 2024

Describe the bug

On the the Ruffle extension's internal player page, some error conditions do not make the panic screen appear, even though they should. Instead, either the loading spinner animation plays forever, or a blank screen appears, either of which is very confusing for users.

  • If an invalid SWF is loaded via the "Select File" button, Ruffle encounters an error while trying to generate the panic message, and so a blank screen is shown instead of the panic screen:
    Uncaught (in promise) TypeError: this.swfUrl is undefined
  • If a non-SWF URL is loaded via the URL box, the loading spinner animation plays forever and the panic screen does not appear. That's despite this error appearing in the console:
    ERROR web/src/navigator.rs:377 Asynchronous error occurred: Invalid SWF: Couldn't read SWF: Invalid data: Invalid SWF

Expected behavior

The panic screen should appear.

Content Location

Example of a non-SWF URL: https://www.miniplay.com/game/renegade-racing

Affected platform

Browser's extension

Operating system

Windows 10

Browser

No response

Additional information

No response

@n0samu n0samu added bug Something isn't working A-web Area: Web & Extensions extension Related to the Ruffle WebExtension labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web Area: Web & Extensions bug Something isn't working extension Related to the Ruffle WebExtension
Projects
None yet
Development

No branches or pull requests

1 participant