Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: Dependencies declared in multiple crates should be workspace dependencies #15460

Open
torokati44 opened this issue Mar 6, 2024 · 2 comments
Labels
A-build Area: Build scripts & CI A-deps Area: Dependencies code-cleanup General improvement of the code base good first issue Good for newcomers

Comments

@torokati44
Copy link
Member

This is to reduce the churn of updating them, and the possibility of them getting accidentally out of sync, therefore dupicated (see for example: #15396).

I have a preliminary list of the most duplicated dependency crates - I can comment it here later if you think it'd be easier to get started with that, instead of discovering them on your own.

Yes, this is shameless "new-contributor-bait". 😉

@torokati44 torokati44 added good first issue Good for newcomers A-deps Area: Dependencies A-build Area: Build scripts & CI code-cleanup General improvement of the code base labels Mar 6, 2024
@homersimpsons
Copy link

If I understand correctly the purpose of this task, the following cargo subcommand may help: https://github.com/mainmatter/cargo-autoinherit

@torokati44
Copy link
Member Author

Yes, sounds like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build scripts & CI A-deps Area: Dependencies code-cleanup General improvement of the code base good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants