Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Dedupe a whole bunch of dependency version specifications #15868

Merged
merged 19 commits into from
Apr 4, 2024

Conversation

Dinnerbone
Copy link
Contributor

Anything that we specified 4 times or more...

core/Cargo.toml Outdated Show resolved Hide resolved
@torokati44
Copy link
Member

torokati44 commented Apr 4, 2024

Partially addresses #15460.

Some more honorable mentions, for a future tweak PR:

byteorder
downcast-rs
fnv
indexmap
serde_json

@torokati44
Copy link
Member

@torokati44
Copy link
Member

torokati44 commented Apr 4, 2024

Also I think we could enable serde/derive globally, like clap/derive.

@torokati44
Copy link
Member

Even ignoring my previous comments about this, I think walkdir is still declared four times.

@Dinnerbone
Copy link
Contributor Author

Dinnerbone commented Apr 4, 2024

Also I think we could enable serde/derive globally, like clap/derive.

I kinda feel like derive shouldn't be workspace wide for either package tbh 😅 If we later get a crate that doesn't need derive, we'd have to go and undo this to allow that to build without needing derive.

But we aren't in that case today so I'll just do that for consistency

Edit: Actually, no, test framework doesn't need derive - so I won't do this.

@torokati44
Copy link
Member

Well then should we consider later making clap/derive not workspace-wide either? 🤔 Or is that definitely needed everywhere?

Copy link
Member

@torokati44 torokati44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

(The last two commits are not in alphabetical order!! 😖🫠😵‍💫🫨😵😫😅😆😁😄)

@Dinnerbone
Copy link
Contributor Author

Well then should we consider later making clap/derive not workspace-wide either? 🤔 Or is that definitely needed everywhere?

It's needed everywhere right now. It's less likely that we'll use clap without derive, than serde without derive - so I'm happy for it to stay this way right now

@Dinnerbone Dinnerbone enabled auto-merge (rebase) April 4, 2024 15:19
@sleepycatcoding
Copy link
Member

The walkdir change is gonna create a local conflict on my save manager branch, but it is whatever. (since I also pulled it out into the workspace)

@torokati44
Copy link
Member

torokati44 commented Apr 4, 2024

I suspect it's gonna cause quite a few conflicts - if anything, due to neighboring line changes... But they should be easy to sort out.

@Dinnerbone Dinnerbone merged commit b7c9c87 into ruffle-rs:master Apr 4, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants