-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Dedupe a whole bunch of dependency version specifications #15868
Conversation
Partially addresses #15460. Some more honorable mentions, for a future tweak PR:
|
Referencing mainmatter/cargo-autoinherit#16 and mainmatter/cargo-autoinherit#2 too. |
Also I think we could enable |
Even ignoring my previous comments about this, I think |
I kinda feel like derive shouldn't be workspace wide for either package tbh 😅 If we later get a crate that doesn't need derive, we'd have to go and undo this to allow that to build without needing derive. But we aren't in that case today so I'll just do that for consistency Edit: Actually, no, test framework doesn't need derive - so I won't do this. |
Well then should we consider later making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot!
(The last two commits are not in alphabetical order!! 😖🫠😵💫🫨😵😫😅😆😁😄)
It's needed everywhere right now. It's less likely that we'll use clap without derive, than serde without derive - so I'm happy for it to stay this way right now |
The |
I suspect it's gonna cause quite a few conflicts - if anything, due to neighboring line changes... But they should be easy to sort out. |
Anything that we specified 4 times or more...