Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building Firefox extension is broken on Node v15.6.0 #2724

Closed
Aaron1011 opened this issue Jan 21, 2021 · 2 comments
Closed

Building Firefox extension is broken on Node v15.6.0 #2724

Aaron1011 opened this issue Jan 21, 2021 · 2 comments
Labels
extension Related to the Ruffle WebExtension firefox

Comments

@Aaron1011
Copy link
Member

Due to archiverjs/node-archiver#491, trying to build the Firefox extension with npm run build is broken on Node v15.6.0. The resulting archive contains a manifest.json with an invalid CRC.

Attempting to load the built firefox_unsigned.xpi into Firefox results in the following error:

There was an error during the temporary add-on installation.
Error details

Component returned failure code: 0x80470002 (NS_BASE_STREAM_CLOSED) [nsIInputStream.available]
@Herschel Herschel added extension Related to the Ruffle WebExtension firefox labels Jan 21, 2021
@Aaron1011
Copy link
Member Author

The root cause is nodejs/node#37027

@Herschel Herschel mentioned this issue Oct 26, 2021
Merged
@relrelb
Copy link
Contributor

relrelb commented Jun 26, 2022

Closing as archiverjs/node-archiver#491 was resolved a long time ago.

@relrelb relrelb closed this as completed Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension Related to the Ruffle WebExtension firefox
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Herschel @Aaron1011 @relrelb