Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: preferentially use node 16 to compile #5551

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

midgleyc
Copy link
Contributor

Node has released 16 as the latest LTS version, leaving 14 as the maintenance version. Preferentially use node 16 to compile.

In theory, it should be more performant. In practice, I can't really see a difference.

Nonetheless, it's worth doing, and I expect our dependent libraries to stop supporting node 12 as time goes by.

@Herschel
Copy link
Member

Does this take care of #2724 as well?

@midgleyc
Copy link
Contributor Author

I expect #2724 was fixed when archiverjs/node-archiver#491 was fixed, which was probably version 5.3.0 (though the issue is several dependencies deep).

Looks like we've hit the same problem with "Required" builds as before: can "Test Node.js 12 / Rust stable / ubuntu-latest" and "Test Node.js 12 / Rust stable / windows-latest" be made non-required (and after this possibly the same builds but with 16 be made required)

@Herschel
Copy link
Member

Yep, I'll force merge this PR, and the new build steps will appear in the repo settings, at which point I can switch the new ones to required.

@Herschel Herschel merged commit 755e545 into ruffle-rs:master Oct 26, 2021
@Herschel
Copy link
Member

Thank you!

@midgleyc midgleyc deleted the use-node-16 branch October 26, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants