Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash detect says I do not have flash when i'm running ruffle #6635

Open
CoolDino1 opened this issue Apr 6, 2022 · 2 comments
Open

Flash detect says I do not have flash when i'm running ruffle #6635

CoolDino1 opened this issue Apr 6, 2022 · 2 comments
Labels
A-web Area: Web & Extensions extension Related to the Ruffle WebExtension

Comments

@CoolDino1
Copy link

Describe the bug

The flash detect on this page (http://kingscall.org/start.html) says 'It appears you do not have Flash! Please go here to get it.' even though I am running Ruffle.

Expected behavior

I do not know what it should have done otherwise but I know it should not say I do not have Flash

Affected platform

Browser's extension

Operating system

Windows 10

Browser

Mozilla Firefox 96.0.2

Additional information

No response

@CoolDino1 CoolDino1 added the bug Something isn't working label Apr 6, 2022
@Toad06
Copy link
Member

Toad06 commented Apr 6, 2022

This also happens on Basilisk with the official Flash Player - a JS script on this website tries to detect the version of Flash but as it's poorly written, any version above 6 is not recognized.

Similar to #5613 (comment) and somehow related to #819.

@Toad06 Toad06 added A-web Area: Web & Extensions and removed bug Something isn't working labels Apr 6, 2022
@n0samu n0samu added the extension Related to the Ruffle WebExtension label Feb 22, 2023
@n0samu
Copy link
Member

n0samu commented Feb 22, 2023

Looks like we need to make the player version reported by Ruffle's JS plugin polyfill customizable. #8961 only covered the player version reported to movies via ActionScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-web Area: Web & Extensions extension Related to the Ruffle WebExtension
Projects
None yet
Development

No branches or pull requests

3 participants