Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Allow the user to choose the version returned in getVersion() #819

Closed
Toad06 opened this issue Jul 6, 2020 · 3 comments
Closed
Labels
enhancement New feature or request

Comments

@Toad06
Copy link
Member

Toad06 commented Jul 6, 2020

I don't know if it's worth the effort these days, but I remember a few old games became unusable as of Flash 10, because of a poor way to detect the Flash version:

ver = Number(getVersion().charAt(4));
if(ver < 7)
{
   attachMovie("ID_VERSIONERR","mcErr",100);
   stop();
}

This is the detection code from "Uncle Sam":
https://www.y8.com/games/uncle_sam

Ruffle could eventually relive them by allowing the user to choose the version returned in getVersion() (or maybe Ruffle could just pretend to be version 99... 😁 though this may also have downsides).

@Herschel Herschel added the enhancement New feature or request label Jul 6, 2020
@Dinnerbone
Copy link
Contributor

We already have some semblance of which version of the Flash player we're emulating, and the idea is that we can use this for the breaking changes introduced around Flash 4-6. Once we have a way to select that, this should be a natural extension.

@Herschel
Copy link
Member

Here's an SWF with a broken version check that would benefit:
https://www.newgrounds.com/portal/view/294434
(broken version check considers Flash Player 32 to be Flash Player 3).

@n0samu
Copy link
Member

n0samu commented Feb 22, 2023

This has been implemented in #8961. Not working for AVM2 yet though - see #9180,

@n0samu n0samu closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants