Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha channel not rendered on images? #7877

Closed
Gargaj opened this issue Sep 5, 2022 · 4 comments
Closed

Alpha channel not rendered on images? #7877

Gargaj opened this issue Sep 5, 2022 · 4 comments
Labels
A-rendering Area: Rendering & Graphics bug Something isn't working unimplemented Issues for functionality that hasn't been implemented yet

Comments

@Gargaj
Copy link

Gargaj commented Sep 5, 2022

Describe the bug

Playing http://www.digshot.com/gameinfopage.php?g=2657 causes a few obvious alpha channel issues - unfortunately they're most visible at the last level, but here's a playthrough video to help you get there: https://www.youtube.com/watch?v=YrlqziJOmW0

image

Expected behavior

It looks to me that the alpha channel on some images isn't honored correctly; the hands on the screenshot should not have the white rectangle around them, and the "END" sign shouldn't have the black background.

Affected platform

Browser's extension

Operating system

Windows 10

Browser

Firefox 104.0.1

Additional information

No response

@Gargaj Gargaj added the bug Something isn't working label Sep 5, 2022
@torokati44
Copy link
Member

torokati44 commented Sep 5, 2022

Looking at the problematic images in ffdec I see them the same way: on a solid background, without any alpha.
Additionally, they are defined using plain DefineBits (6) tags, which have no support for any transparency.
When running the SWF in the desktop player with RUST_LOG=warn set, I get a couple messages like these:

[2022-09-05T15:57:25Z WARN  ruffle_core::display_object] Blend mode 'screen' is unsupported and will not render correctly.
[2022-09-05T15:57:25Z WARN  ruffle_core::display_object] Blend mode 'lighten' is unsupported and will not render correctly.

So, this is likely just another case of #58.

@torokati44 torokati44 added A-rendering Area: Rendering & Graphics unimplemented Issues for functionality that hasn't been implemented yet labels Sep 5, 2022
@Lord-McSweeney
Copy link
Collaborator

The blend modes PR fixes this issue.

@torokati44
Copy link
Member

Cross-referencing: #8262, #9134

@torokati44
Copy link
Member

torokati44 commented Feb 3, 2023

This is fixed now, at least on desktop, and in WebGL 2-capable browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rendering Area: Rendering & Graphics bug Something isn't working unimplemented Issues for functionality that hasn't been implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants