-
-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: Enable wgpu-webgl by default #9134
Conversation
Oh, I'd love the get those rendering goodies you put together in the past months to everyone... One consequence, losing WebGPU support, doesn't matter the slightest, at this point in time, in my opinion. PS.: I'm sorry if any or all of these were already addressed on Discord, I'm really behind on my reading there... |
@torokati44 Right now there's a fallback to the "normal" WebGL backend if they can't support the wgpu one. These people will be:
So for those people, nothing changes, they'll use the old webgl-or-canvas fallback. That's something we should discuss in the future if we want to keep that backend or drop them to canvas entirely, but not something for today I think. For the seconds-long hang, as far as I know it should be fast to startup now, it's significantly less pipelines. @adrian17 will have to confirm, but I haven't seen him mention it in his recent tests. |
Alright, awesome! \o/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ready to merge this, once we have confirmation from @adrian17 and other affected users that this no longer hangs on startup.
I still think we should do one more round of testing with NG before merging this. For the record, here's what Tom said about the previous build:
But given the many improvements since the last build I sent him, I think it's pretty likely NG won't see problems this time. Just want to wait for confirmation of that, though. |
Oh and along the lines of what Adrian17 was pointing out earlier, I'm seeing a significant new startup delay. Tested on Windows 10 in Firefox and Chromium with the demo and extension. I imagine this could get quite annoying for impatient users (which is probably many of them). ruffle_demo_startup.mp4ruffle_wgpu_demo_startup.mp4 |
I can confirm that with Dinnerbone/wgpu@f1fdd1c, the startup delay is drastically reduced! Still not as fast as WebGL, but I think this is good enough. ruffle_wgpu_demo_startup-2.mp4 |
The WASM bundles increased from 6 MB to 10 MB after this change. Not sure if this was known or expected, but I went to upgrade Ruffle for my self hosted use and noticed since Jan 15th, 2023 it was around 6 MB and now it's at 11 MB. The biggest jump I saw was from this commit/release it seemed. |
Yes that is expected, unfortunately |
Let's do it? Any objections?
Newgrounds has been running an old build pre-optimisations and as far as we've seen, it's been great and only had the buffer bug, which #9133 deals with (they'll fall back to regular webgl).