Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Enable wgpu-webgl by default #9134

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

Dinnerbone
Copy link
Contributor

Let's do it? Any objections?

Newgrounds has been running an old build pre-optimisations and as far as we've seen, it's been great and only had the buffer bug, which #9133 deals with (they'll fall back to regular webgl).

@torokati44
Copy link
Member

Oh, I'd love the get those rendering goodies you put together in the past months to everyone... ☺️

One consequence, losing WebGPU support, doesn't matter the slightest, at this point in time, in my opinion.
Another is: Will this raise the minimum browser/HW requirements at all? I'm thinking of WebGL1, or any optional extensions that will be needed for this to work... If there's a runtime fallback to the classic WebGL backend, this is a moot point.
Also, has that seconds-long hang at the beginning experienced by Adrian on Windows (IIRC) been resolved?

PS.: I'm sorry if any or all of these were already addressed on Discord, I'm really behind on my reading there...

@Dinnerbone
Copy link
Contributor Author

@torokati44 Right now there's a fallback to the "normal" WebGL backend if they can't support the wgpu one. These people will be:

  • People with WebGL1.0
  • People with the buffer bug (a range of intel igpus) - note that these people will have issues on webgl backend too, it's just less noticeable
  • People with a broken or insufficient WebGL2.0 setup for our needs

So for those people, nothing changes, they'll use the old webgl-or-canvas fallback. That's something we should discuss in the future if we want to keep that backend or drop them to canvas entirely, but not something for today I think.

For the seconds-long hang, as far as I know it should be fast to startup now, it's significantly less pipelines. @adrian17 will have to confirm, but I haven't seen him mention it in his recent tests.

@torokati44
Copy link
Member

Alright, awesome! \o/

Copy link
Member

@Aaron1011 Aaron1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ready to merge this, once we have confirmation from @adrian17 and other affected users that this no longer hangs on startup.

@n0samu
Copy link
Member

n0samu commented Jan 13, 2023

I still think we should do one more round of testing with NG before merging this. For the record, here's what Tom said about the previous build:

Heads up, I've switched Newgrounds to the latest nightly because I've seen a decent amount of people at this point where the experimental build wasn't working. I'm down to test another build any time though!

But given the many improvements since the last build I sent him, I think it's pretty likely NG won't see problems this time. Just want to wait for confirmation of that, though.

@n0samu
Copy link
Member

n0samu commented Jan 13, 2023

Oh and along the lines of what Adrian17 was pointing out earlier, I'm seeing a significant new startup delay. Tested on Windows 10 in Firefox and Chromium with the demo and extension. I imagine this could get quite annoying for impatient users (which is probably many of them).

ruffle_demo_startup.mp4
ruffle_wgpu_demo_startup.mp4

@n0samu
Copy link
Member

n0samu commented Jan 15, 2023

I can confirm that with Dinnerbone/wgpu@f1fdd1c, the startup delay is drastically reduced! Still not as fast as WebGL, but I think this is good enough.

ruffle_wgpu_demo_startup-2.mp4

@DustinBrett
Copy link

The WASM bundles increased from 6 MB to 10 MB after this change. Not sure if this was known or expected, but I went to upgrade Ruffle for my self hosted use and noticed since Jan 15th, 2023 it was around 6 MB and now it's at 11 MB. The biggest jump I saw was from this commit/release it seemed.

@n0samu
Copy link
Member

n0samu commented Jun 5, 2023

Yes that is expected, unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants