Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm2: Work on flash.system.Capabilities #10945

Merged
merged 1 commit into from
May 19, 2023

Conversation

Lord-McSweeney
Copy link
Collaborator

@Lord-McSweeney Lord-McSweeney commented May 5, 2023

Eventually, code from #10469 can be reused to implement the rest of the flash.system.Capabilities getters.

Fixes #9180.

@Lord-McSweeney Lord-McSweeney force-pushed the avm2-player-version branch 2 times, most recently from 64c2e7a to a66b699 Compare May 6, 2023 14:56
@iwannabethedev
Copy link
Contributor

I do not understand Rust or this piece of Ruffle well enough to really give good feedback, but it looks good to me overall.

I imagine that this can be complicated to test in an automated way. Have you tested the two new properties manually?

I think someone else should review as well, but otherwise this looks good to me as is. You are welcome to close the comments that I made once you have read them.

@Lord-McSweeney
Copy link
Collaborator Author

I've tested both the properties, with --player-type, and compiling this branch and running a SWF in the browser/desktop app (which correctly reports StandAlone and PlugIn).

@iwannabethedev
Copy link
Contributor

I believe that @n0samu thinks this looks good, and I myself think it looks good (with my limited insight into Rust and this part of the codebase), so I believe it is ready to be merged once rebased.

@Lord-McSweeney Lord-McSweeney force-pushed the avm2-player-version branch 2 times, most recently from 1d2e8a8 to 386bd85 Compare May 14, 2023 05:16
… mark the other Capabilities getters as stubs)
@Aaron1011 Aaron1011 force-pushed the avm2-player-version branch from a3aa441 to e6ec77c Compare May 19, 2023 21:40
@Aaron1011 Aaron1011 enabled auto-merge (rebase) May 19, 2023 21:40
@Aaron1011 Aaron1011 merged commit 0948bf7 into ruffle-rs:master May 19, 2023
@Lord-McSweeney Lord-McSweeney deleted the avm2-player-version branch May 21, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player version config doesn't work in AVM2
4 participants