render/core: Fix of panic bug and rendering bug in #10955 . #11006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwannabethedev
force-pushed
the
render_issue_10955
branch
from
02cb4d1 to
19b6cf6
Compare
iwannabethedev
changed the title
iwannabethedev
force-pushed
the
render_issue_10955
branch
from
19b6cf6 to
b3f6e4a
Compare
|
I would like to request a review from both @n0samu and @relrelb , such that we can get the changes merged quickly and fix the issues. CC @Dinnerbone . |
iwannabethedev
changed the title
Closed
iwannabethedev
force-pushed
the
render_issue_10955
branch
from
b3f6e4a to
a4e1663
Compare
Taken directly from this commit, credits to Dinnerbone: Dinnerbone@9b76090
iwannabethedev
force-pushed
the
render_issue_10955
branch
from
a4e1663 to
6600caa
Compare
|
I have tried running the .swf file in #11017 , but when I click the button to "Play", I only get re-directed to newgrounds.com. |
iwannabethedev
force-pushed
the
render_issue_10955
branch
from
b218fe7 to
cc0b05c
Compare
adrian17
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With help from and credit to @Dinnerbone and @n0samu , we have a probable fix for #10955 .
Credit for 19b6cf6 goes fully to @Dinnerbone .
I have run the game "Dont escape 3", and the introduction part of it works now, without any panics or rendering issues as far as I can tell.
See also #10583 .
Fixes #10955 .
Fixes #11007 .
Might fix #11017 .