Add prependRotation, copyRowTo and copyRowFrom #11698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron1011
reviewed
Jun 23, 2023
|
Could you add a test for these methods? |
I don not have enough AS3 Knowledge to do so currently :/ |
|
I can write a test when I get access to my desktop again. |
|
I see, thank you! |
Aaron1011
force-pushed
the
Feature/prependRotation
branch
from
b8d46a9 to
6d41304
Compare
|
@Fancy2209 I added some tests, and fixed some bugs (the row index wasn't being checked, and you were writing to a copy of the array via the getter, not the underlying array). |
Aaron1011
force-pushed
the
Feature/prependRotation
branch
from
1013f27 to
cc2041a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prependRotation is based on a suggestion by Adrian on Discord
copyRowTo and copyRowFrom implmentations are from OpenFL
Fixes #11688