Scale filter values when the filtered objects are scaled #11798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
force-pushed
the
filters
branch
2 times, most recently
from
a08796a to
c1031c0
Compare
relrelb
reviewed
Jun 29, 2023
Dinnerbone
added
the
waiting-on-review
Aaron1011
approved these changes
Jul 2, 2023
…ation of size upfront
Lord-McSweeney
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make blur_x/blur_y bigger (or smaller) when the object is scaled, which seems to match Flash (thanks @torokati44 for pointing that out!)
Also implemented @MrCheeze's idea of using accumulative values for the pass-scaling, so we can (later) calculate the size upfront correctly