avm2: Implement NetConnection.connect with a null command
#11815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| args: &[Value<'gc>], | ||
| ) -> Result<Value<'gc>, Error<'gc>> { | ||
| let this = this.unwrap(); | ||
| if let Value::Null = args[0] { |
There was a problem hiding this comment.
This should probably be args.get_value(0) with ParametersExt. Also, it is currently theoretically possible for this to be None, but Adrian is planning on fixing that soon.
There was a problem hiding this comment.
args.get_value is defined as self[index], so it does the same thing.
There was a problem hiding this comment.
The reason the ParametersExt functions are defined that way is so that it's easy to change/intercept every parameter lookup by changing just the get_value function. Otherwise there's no reason for get_value to be defined.
There was a problem hiding this comment.
I don't think that's true - these are just convenience methods.
Dinnerbone
approved these changes
Jul 5, 2023
|
Progresses Cardboard Box Assembler (#11921). |
Aaron1011
force-pushed
the
net-connection-connect
branch
from
2d60211 to
9ca0d73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.