render: Implement more Pixelbender opcodes, and fix matrices #11896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
reviewed
Jul 5, 2023
Comment on lines
11
to
13
| * law. Dissemination of this information or reproduction of this material is | ||
| * strictly forbidden unless prior written permission is obtained from Adobe | ||
| * Systems Incorporated. |
There was a problem hiding this comment.
From the comments below, this is from https://github.com/nojvek/pixelbender/blob/master/twirl/twirl.pbk, which has no such license on it (and it's not like we're distributing it)- where did the license come from?
Aaron1011
force-pushed
the
extra-pixelbender-opcodes
branch
from
c45c31e to
a460692
Compare
|
Squash this on merge please; I don't want the old license in the history and have awkward questions if someone does a code scan in the future |
Dinnerbone
approved these changes
Jul 9, 2023
Matrices don't actually get their own registers - they are stored in normal float registers, with each column of the matrix getting its own register. The exception is float2x2, which is stored in a single vec4 (this is visible to PixelBender bytecode, which writes to a single vector, and then uses it as an M2x2 channel).
Aaron1011
force-pushed
the
extra-pixelbender-opcodes
branch
from
8cb3f99 to
3ecf114
Compare
This was referenced Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matrices don't actually get their own registers - they are stored in normal float registers, with each column of the matrix getting its own register. The exception is float2x2, which is stored in a single vec4 (this is visible to PixelBender bytecode, which writes to a single vector, and then uses it as an M2x2 channel).